Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL tests: replace IT_test_only.csv-spec with required_feature #108319

Closed
4 tasks done
nik9000 opened this issue May 6, 2024 · 2 comments
Closed
4 tasks done

ESQL tests: replace IT_test_only.csv-spec with required_feature #108319

nik9000 opened this issue May 6, 2024 · 2 comments
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@nik9000
Copy link
Member

nik9000 commented May 6, 2024

Description

We end files with IT_test_only for ESQL's csv-spec tests to skip tests in our stripped down test runner, CsvTests, and just run them in our integration tests. We use required_features for versioning. Nik doesn't like the file ending version - it's not pretty! Let's use the required_featues for skipping CsvTests. It's pretty easy if you already have a feature - and if you don't, we should be adding those so we don't need the node version anyway.

Here's the list of files to rename:

@nik9000 nik9000 added >enhancement needs:triage Requires assignment of a team area label :Analytics/ES|QL AKA ESQL labels May 6, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 6, 2024
@nik9000 nik9000 closed this as completed May 9, 2024
@nik9000
Copy link
Member Author

nik9000 commented May 9, 2024

All done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

2 participants