ESQL: Rework integration-only csv testing #108313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reworks the integration-test-only csv testing for `metadata` to use the `required_feature:` syntax instead of the `-IT_tests_only` extension. This is a little more flexible and way nicer on the eyes.
nik9000
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
bpintea
reviewed
May 6, 2024
| */ | ||
| assumeTrue("Test " + testName + " is not enabled", isEnabled(testName, Version.CURRENT)); | ||
| assumeFalse("metadata fields aren't supported", testCase.requiredFeatures.contains(EsqlFeatures.METADATA_FIELDS.id())); |
There was a problem hiding this comment.
Since we're introducing METADATA_FIELDS now in 8.15, wouldn't the tests updated above no longer be run against 8.13 and 8.14 bwc runs? Is this intended?
There was a problem hiding this comment.
Yeah! Sorry, that's a sad side effect of dropping that version thingy - which we're supposed to be doing too. I figured I'd backport to 8.14 and ignore 8.13 because we're not likely to cut any more of those.
nik9000
added
auto-merge-without-approval
4 tasks
💔 Backport failed
You can use sqren/backport to manually backport by running |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
May 6, 2024
This reworks the integration-test-only csv testing for `metadata` to use the `required_feature:` syntax instead of the `-IT_tests_only` extension. This is a little more flexible and way nicer on the eyes.
|
Backport is #108326 |
nik9000
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the integration-test-only csv testing for
metadatato use therequired_feature:syntax instead of the-IT_tests_onlyextension. This is a little more flexible and way nicer on the eyes.