Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Embedded node client should disable HTTP #11952

Closed
pickypg opened this issue Jun 30, 2015 · 2 comments
Closed

[Docs] Embedded node client should disable HTTP #11952

pickypg opened this issue Jun 30, 2015 · 2 comments
Assignees
Labels
>docs General docs changes >enhancement good first issue low hanging fruit

Comments

@pickypg
Copy link
Member

pickypg commented Jun 30, 2015

The Java API documentation talks about the creation of an embedded node client, but it does not talk about the negatives. One oft-surprising negative is that, because it's a full node, it also provides an HTTP port for access.

For embedded client nodes, this should be disabled by default. For standalone client nodes (the main use case for client nodes), this should be on by default.

Node node =
    nodeBuilder()
        .settings(ImmutableSettings.settingsBuilder().put("http.enabled", false))
        .client(true)
    .node();

Client client = node.client();
@pickypg pickypg added >enhancement >docs General docs changes good first issue low hanging fruit labels Jun 30, 2015
@dadoonet
Copy link
Member

@pickypg you wrote almost everything ! Why not sending a PR ?

Wanna do it ?

@pickypg
Copy link
Member Author

pickypg commented Jul 31, 2015

Closed by 8efa18e (master), 2461e91 (1.7), d4b7e12 (1.6)

@pickypg pickypg closed this as completed Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes >enhancement good first issue low hanging fruit
Projects
None yet
Development

No branches or pull requests

2 participants