Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _index field non-configurable #12329

Closed
clintongormley opened this issue Jul 19, 2015 · 4 comments · Fixed by #12356
Closed

Make _index field non-configurable #12329

clintongormley opened this issue Jul 19, 2015 · 4 comments · Fixed by #12356
Assignees
@rjernst
Labels
>enhancement good first issue low hanging fruit :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1

Comments

@clintongormley
Copy link

Since #12027 was merged, the _index field can be used in queries, aggregations, sorting, and scripting, even though it is not indexed.

I can't see any reason now why we would allow users to set:

"_index": { "enabled": true }
@clintongormley clintongormley added >enhancement v2.0.0-beta1 good first issue low hanging fruit :Search/Mapping Index mappings, including merging and defining field types labels Jul 19, 2015
@clintongormley
Copy link
Author

@rjernst do you agree?

rjernst added a commit to rjernst/elasticsearch that referenced this issue Jul 21, 2015
@rjernst
Mappings: Remove ability to configure _index
1c99626 
The `_index` field is now a completely virtual field thanks
to elastic#12027. It is no longer necessary to index the actual value
of the index name.

closes elastic#12329
@rjernst rjernst mentioned this issue Jul 21, 2015
Merged
@rjernst
Copy link
Member

rjernst commented Jul 21, 2015

I do agree. I opened #12356.

@clintongormley clintongormley mentioned this issue Jul 23, 2015
Closed
@rjernst rjernst mentioned this issue Nov 28, 2015
Closed
@clintongormley clintongormley mentioned this issue Nov 30, 2015
Closed
@Digital2Slave
Copy link

Soga.

@big-peter
Copy link

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
>enhancement good first issue low hanging fruit :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ability to configure _index rjernst/elasticsearch
4 participants
@clintongormley @rjernst @Digital2Slave @big-peter