Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space in directory structure fails plugin binary #12504

Closed
electrical opened this issue Jul 28, 2015 · 3 comments
Closed

Space in directory structure fails plugin binary #12504

electrical opened this issue Jul 28, 2015 · 3 comments
Assignees
@nik9000
Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure

Comments

@electrical
Copy link
Contributor

When one of the parent directories has a space in there the plugin binary can't find the correct path.

$ pwd
/home/richard/temp dir/elasticsearch-1.7.0
$ ./bin/plugin
Error: Could not find or load main class dir.elasticsearch-1.7.0.config
@electrical electrical added the :Core/Infra/Plugins Plugin API and infrastructure label Jul 28, 2015
@nik9000
Copy link
Member

nik9000 commented Jul 28, 2015

Confirmed on OSX and Ubuntu.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Jul 28, 2015
@nik9000
Plugin script: Fix ES_HOME with spaces
a1515da 
When ES_HOME has spaces we get funky "cannot find main class <part of a
directory>" errors. This makes them stop by escaping directories and using
eval instead of exec.

Closes elastic#12504
This was referenced Jul 28, 2015
Closed
Merged
@nik9000 nik9000 self-assigned this Jul 28, 2015
@nik9000
Copy link
Member

nik9000 commented Jul 28, 2015

Assigned to myself as I sent a PR for it. Anyone else can take it if they want it and think they can make a better pull request.

nik9000 added a commit that referenced this issue Aug 3, 2015
@nik9000
Plugin script: Fix ES_HOME with spaces
281d6f8 
When ES_HOME has spaces we get funky "cannot find main class directory>"
errors. This makes them stop by escaping directories and using eval instead
of exec.

Closes #12504
@nik9000
Copy link
Member

nik9000 commented Aug 3, 2015

Ok - we have a fix merged for 1.7 and now I'll need to forward port that to master.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Aug 3, 2015
@nik9000
Plugin script: Fix spaces
1b5bf17 
Fixes ES_HOME with spaces and installing plugins from a local directory
with spaces.

Closes elastic#12504
@nik9000 nik9000 mentioned this issue Aug 3, 2015
Merged
@dblado dblado mentioned this issue Oct 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
>bug :Core/Infra/Plugins Plugin API and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nik9000 @electrical