Refactor StoreRecoveryService to be a simple package private util class #13766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>enhancement
review
:Distributed/Recovery
|
@bleskes if you have time :) |
| import static org.elasticsearch.common.unit.TimeValue.timeValueMillis; | ||
|
|
||
| /** | ||
| * This package private utility class encapsulates the logic to recover an index shard from either and existing index on |
|
I left mostly cosmetic comments, I know I'm not @bleskes but this LGTM :) |
|
Also, I think this is much cleaner than the previous code, so thanks @s1monw! |
|
Looks good to me because @dakrone said so . I don't need to look ;) On 29 sep. 2015 10:50 AM +0200, Lee Hinmannotifications@github.com, wrote:
|
s1monw
force-pushed
the
store_recovery_helper
branch
from
b16a1e0
to
a1731fe
Compare
|
LGTM |
StoreRecoveryService used to be a pretty heavy class with lots of dependencies. This class was basically not testable in isolation and had an async API with a listener. This commit refactors this class to be a simple utility classs with a sync API hidden behind the IndexShard interface. It includes single node tests and moves all the async properities to the caller side. Note, this change also removes the mapping update on master from the store recovery code since it's not needed anymore in 3.0 because all stores have been subject to sync mapping updates such that the master already has all the mappings for documents that made it into the transaction log. Closes elastic#13766
s1monw
force-pushed
the
store_recovery_helper
branch
from
a1731fe
to
3b5ed08
Compare
s1monw
added a commit
that referenced
this pull request
Sep 29, 2015
Refactor StoreRecoveryService to be a simple package private util class
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Oct 25, 2015
elastic#13766 removed the previous async trigger of shard recovery with the goal of making it easier to test. The async constructs were folded into IndicesClusterStateService. The change is good but it also made the state managment on the shard level async, while it was previously done on the cluster state thread, before triggering the recoveries (but it was hard to see that). This caused state related race conditions and some build failures (elastic#14115). To fix, the shard state management is now pulled out of the recovery code and made explicit in IndicesClusterStateService, and runs on the cluster state update thread. Closes elastic#14115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StoreRecoveryService used to be a pretty heavy class with lots of dependencies.
This class was basically not testable in isolation and had an async API with a listener.
This commit refactors this class to be a simple utility classs with a sync API hidden behind
the IndexShard interface. It includes single node tests and moves all the async properities to
the caller side.
Note, this change also removes the mapping update on master from the store recovery code since
it's not needed anymore in 3.0 because all stores have been subject to sync mapping updates such
that the master already has all the mappings for documents that made it into the transaction log.