Rip the grooviness out of 'messy tests' in groovy plugin #13837
Labels
Comments
rmuir
added
>test
|
See #13834 for more information. The referred package-info is https://github.com/rmuir/elasticsearch/blob/groovy_factor_out/plugins/lang-groovy/src/test/java/org/elasticsearch/messy/tests/package-info.java |
javanna
added a commit
to javanna/elasticsearch
that referenced
this issue
Oct 6, 2015
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this issue
Jul 7, 2016
After elastic#13834 many tests that used Groovy scripts (for good or bad reason) in their tests have been moved in the lang-groovy module and the issue elastic#13837 has been created to track these messy tests in order to clean them up. This commit moves more tests back in core, removes the dependency on Groovy, changes the scripts in order to use the mocked script engine, and change the tests to integration tests.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this issue
Jul 25, 2016
After elastic#13834 many tests that used Groovy scripts (for good or bad reason) in their tests have been moved in the lang-groovy module and the issue elastic#13837 has been created to track these messy tests in order to clean them up. This commit moves more tests back in core, removes the dependency on Groovy, changes the scripts in order to use the mocked script engine, and change the tests to integration tests.
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this issue
Aug 1, 2016
After elastic#13834 many tests that used Groovy scripts (for good or bad reason) in their tests have been moved in the lang-groovy module and the issue elastic#13837 has been created to track these messy tests in order to clean them up. The work started with elastic#19280, elastic#19302 and elastic#19336 and this PR moves the remaining messy tests back in core, removes the dependency on Groovy, changes the scripts in order to use the mocked script engine, and change the tests to integration tests. It also moves IndexLookupIT test back (even if it has good chance to be removed soon) and fixes its tests. It also changes AbstractQueryTestCase to use custom script plugins in tests. closes elastic#13837
|
Many messy tests have been cleaned recently in #19280, #19302, #19336 and #19621. Most of the tests have been moved back in their original places and converted back again into integration tests while the dependency on Groovy has been replaced by mocked scripts. It's not perfect since some tests would have benefit to be changed into unit or simplier tests but I think that's still a good move. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These these tests belong in core, and were just moved temporarily.
We should clean them up one by one...
The text was updated successfully, but these errors were encountered: