Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node.(other) docs #14429

Closed
markwalkom opened this issue Nov 2, 2015 · 1 comment
Closed

Update node.(other) docs #14429

markwalkom opened this issue Nov 2, 2015 · 1 comment
Assignees
@debadair
Labels
>docs General docs changes good first issue low hanging fruit

Comments

@markwalkom
Copy link
Contributor

Here we only list node.data when there is .master as well.

We should reflect this in the docs as a I've seen a few people ask about this just recently.
@markwalkom markwalkom added >docs General docs changes good first issue low hanging fruit labels Nov 2, 2015
@arinto
Copy link

arinto commented Nov 2, 2015

+1. Original discussion thread is here.

@markwalkom markwalkom mentioned this issue Nov 3, 2015
Closed
@palecur palecur self-assigned this Dec 3, 2015
@clintongormley clintongormley assigned debadair and unassigned palecur Jan 15, 2016
@pickypg pickypg mentioned this issue Jan 29, 2016
Closed
clintongormley pushed a commit that referenced this issue Jan 30, 2016
@pickypg @clintongormley
[DOCS] Adding node.max_local_storage_nodes setting
e0e08c0 
This setting was missing from the docs, so I added it. However, I also
completely rewrote the nodes documentation page because it was mostly
talking about client nodes with some issues, without ever discussing
master nodes, or even tribe nodes. All nodes should be listed on a
"nodes" documentation page.

Fixes #15903
Fixed #14429
clintongormley pushed a commit that referenced this issue Jan 30, 2016
@pickypg @clintongormley
[DOCS] Adding node.max_local_storage_nodes setting
d354851 
This setting was missing from the docs, so I added it. However, I also
completely rewrote the nodes documentation page because it was mostly
talking about client nodes with some issues, without ever discussing
master nodes, or even tribe nodes. All nodes should be listed on a
"nodes" documentation page.

Fixes #15903
Fixed #14429
clintongormley pushed a commit that referenced this issue Jan 30, 2016
@pickypg @clintongormley
[DOCS] Adding node.max_local_storage_nodes setting
6b4fe20 
This setting was missing from the docs, so I added it. However, I also
completely rewrote the nodes documentation page because it was mostly
talking about client nodes with some issues, without ever discussing
master nodes, or even tribe nodes. All nodes should be listed on a
"nodes" documentation page.

Fixes #15903
Fixed #14429
clintongormley pushed a commit that referenced this issue Jan 30, 2016
@pickypg @clintongormley
[DOCS] Adding node.max_local_storage_nodes setting
5a419d0 
This setting was missing from the docs, so I added it. However, I also
completely rewrote the nodes documentation page because it was mostly
talking about client nodes with some issues, without ever discussing
master nodes, or even tribe nodes. All nodes should be listed on a
"nodes" documentation page.

Fixes #15903
Fixed #14429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debadair debadair

Labels
>docs General docs changes good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@debadair @palecur @arinto @markwalkom