Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading error message for geo_point parse failure #15965

Closed
pickypg opened this issue Jan 13, 2016 · 3 comments
Closed

Misleading error message for geo_point parse failure #15965

pickypg opened this issue Jan 13, 2016 · 3 comments
Assignees
@imotov
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement good first issue low hanging fruit

Comments

@pickypg
Copy link
Member

pickypg commented Jan 13, 2016

Even without enabling geohash functionality for the geo_point type, if it fails to parse a string in the format of "<lat>,<lon>", then it throws a misleading error:

Caused by: org.elasticsearch.ElasticsearchIllegalArgumentException: the character '.' is not a valid geohash character

It would be extremely useful to show the:

  • Name of the malformed field
  • The value of the malformed field (in addition to the reason the field failed to parse)

In my case, a field was accidentally mapped as a geo_point when it was meant to be an IP address, which made it hard to determine which field was the cause.

{
  "ipv4_src_addr" : "127.0.0.1"
}
@clintongormley clintongormley added the good first issue low hanging fruit label Jan 14, 2016
@mortonsykes
Copy link

Hi i am new to Elastic Search and would be interested in taking this issue.

C-Bish pushed a commit to C-Bish/elasticsearch that referenced this issue Mar 23, 2017
Fixed Issue elastic#15965 - Included further information for exceptio…
ecc4b65 
…ns when a geo-point type field is entered incorrectly

Squashed commits:
Created an exception when a full stop is used for a geopoint type
Changed the exception message to include further information regarding the malformed field
kblincoe added a commit to kblincoe/elasticsearch that referenced this issue Apr 3, 2017
@kblincoe
Merge pull request #158 from C-Bish/master
310998c 
Fixed Issue elastic#15965 - Included further information for exceptions when…
@lcawl lcawl added :Core/Infra/Core Core issues without another label and removed :Exceptions labels Feb 13, 2018
@jasontedor jasontedor added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Mar 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jasontedor jasontedor removed the :Core/Infra/Core Core issues without another label label Mar 14, 2018
@imotov imotov assigned imotov and unassigned nknize Dec 10, 2018
@imotov
Copy link
Contributor

imotov commented Dec 10, 2018

It looks like the situation is a bit better now. We are now getting unsupported symbol [.] in geohash [127.0.0.1] but I think we can improve it by adding the field name and type as well.

imotov added a commit to imotov/elasticsearch that referenced this issue Dec 12, 2018
@imotov
Geo: Adds a name of the field to geopoint parsing errors
7e5f382 
Adds the field name and type to geo_point parsing errors.

Closes elastic#15965
@imotov imotov mentioned this issue Dec 12, 2018
Merged
imotov added a commit that referenced this issue Dec 13, 2018
@imotov
Geo: Adds a name of the field to geopoint parsing errors (#36529)
7446f75 
Adds the field name and type to geo_point parsing errors.

Closes #15965
imotov added a commit that referenced this issue Dec 13, 2018
@imotov
Geo: Adds a name of the field to geopoint parsing errors (#36529)
047c53c 
Adds the field name and type to geo_point parsing errors.

Closes #15965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement good first issue low hanging fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@clintongormley @imotov @nknize @pickypg @jasontedor @mortonsykes @elasticmachine @lcawl