Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch scripts to use bash #18251

Merged
merged 1 commit into from
May 10, 2016
Merged

Switch scripts to use bash #18251

merged 1 commit into from
May 10, 2016

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented May 10, 2016

This commit switches the command-line scripts to use bash instead of sh
so that we can take advantage of features that bash provides like
arrays.

Closes #14002

This commit switches the command-line scripts to use bash instead of sh
so that we can take advantage of features that bash provides like
arrays.
@jasontedor jasontedor added >enhancement review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v5.0.0-alpha3 labels May 10, 2016
@nik9000
Copy link
Member

nik9000 commented May 10, 2016

I still like it. Quoting things in sh is pain. bash's arrays make this so much nicer.

@jasontedor
Copy link
Member Author

jasontedor commented May 10, 2016

Quoting things in sh is pain. bash's arrays make this so much nicer.

That's exactly what is motivating this PR.

@jasontedor jasontedor merged commit ef6a763 into elastic:master May 10, 2016
@jasontedor jasontedor deleted the bashful branch May 10, 2016 19:06
@dakrone
Copy link
Member

dakrone commented May 10, 2016

I know this is already merged, but can we add bash as a dependency for our RPM and DEB packages now?

@dakrone
Copy link
Member

dakrone commented May 10, 2016

I also think this should be marked as "breaking" and have a note in the migration guide

@nik9000
Copy link
Member

nik9000 commented May 10, 2016

Both of those things are good. It is "breaking" for folks that are trying to support Elasticsearch outside of our packages. Some folks will have to react and that'll help.

@jasontedor
Copy link
Member Author

I know this is already merged, but can we add bash as a dependency for our RPM and DEB packages now?

I also think this should be marked as "breaking" and have a note in the migration guide

I opened #18259.

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team v5.0.0-alpha3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lets talk about switching bin/elasticsearch to bash
4 participants