Simplify AnalysisService #19828
Assignees
Labels
Comments
nik9000
added
>enhancement
:Core/Infra/Core
johtani
added a commit
to johtani/elasticsearch
that referenced
this issue
Aug 29, 2016
Change implementation but not fix some error in UT Closes elastic#19828
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this issue
Sep 22, 2016
…ping Today we hold on to all possible tokenizers, tokenfilters etc. when we create an index service on a node. This was mainly done to allow the `_analyze` API to directly access all these primitve. We fixed this in elastic#19827 and can now get rid of the AnalysisService entirely and replace it with a simple map like class. This ensures we don't create a gazillion long living objects that are entirely useless since they are never used in most of the indices. Also those objects might consume a considerable amount of memory since they might load stopwords or synonyms etc. Closes elastic#19828
s1monw
added a commit
that referenced
this issue
Sep 23, 2016
…ping (#20627) Today we hold on to all possible tokenizers, tokenfilters etc. when we create an index service on a node. This was mainly done to allow the `_analyze` API to directly access all these primitive. We fixed this in #19827 and can now get rid of the AnalysisService entirely and replace it with a simple map like class. This ensures we don't create a gazillion long living objects that are entirely useless since they are never used in most of the indices. Also those objects might consume a considerable amount of memory since they might load stopwords or synonyms etc. Closes #19828
s1monw
added a commit
that referenced
this issue
Sep 23, 2016
…ping (#20627) Today we hold on to all possible tokenizers, tokenfilters etc. when we create an index service on a node. This was mainly done to allow the `_analyze` API to directly access all these primitive. We fixed this in #19827 and can now get rid of the AnalysisService entirely and replace it with a simple map like class. This ensures we don't create a gazillion long living objects that are entirely useless since they are never used in most of the indices. Also those objects might consume a considerable amount of memory since they might load stopwords or synonyms etc. Closes #19828
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to simplify
AnlaysisServiceso we keep fewer objects on heap per index. This means removing thetokenizer,charFilter, andtokenFiltermethods and their support from theAnalysisService. Those methods are only used to build analyzers, both during analysis service startup and during the_analyzeAPI. I've opened #19827 to stop using those methods in the_analyzeAPI. After that is done, we can work on this to remove the methods entirely.The text was updated successfully, but these errors were encountered: