Switch InternalShardLock from using LockObtainFailedException to a different exception #19978
Assignees
Comments
|
+1 hijacking this exception is crying wolf, it freaks me out if i see it, especially if it does not contain the expected contents. Lets please not use it for any other purpose. |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Aug 16, 2016
…ption `LobObtainFailedException` should be reserved for on-disk locks that Lucene attempts (like `write.lock`). This switches our in-memory semaphore locks for shards to use a different exception. Additionally, ShardLockObtainFailedException no longer subclasses IOException, since no IO is being done is this case. Resolves elastic#19978
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the documentation for
LockObtainFailedException:This exception is thrown when the <code>write.lock</code> could not be acquired.We should not use this exception for the in-memory semaphore that's part of NodeEnvironment, we should use a different exception class.
The text was updated successfully, but these errors were encountered: