-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reindex cancel and status don't work via transport client #19979
Comments
This can be tested by removing the @ClusterScope annotation from ReindexTestCase, which currently disables transport client in all of the reindex integration tests. One of the problems that we would have caught using transport client is #19977, another one is this issue. Once we have resolved this we can enable the transport client in those tests. |
So I added that annotation because it was on the test case from that I cribbed the module test from. I can't remember which one it was, but I expect we use this annotation all over the place for dubious reasons. Maybe we should remove go through the uses and prune them? |
I'd put the method in ActionPlugin because tasks are always paired with some action. There is also a |
I had a quick look, and I don't see that many usages, most seem legit, but sure we should probably go over the tests that use it and re-evaluate. |
I can fix this on Monday if no one else claims it first. |
Claimed. I'll work on it this morning. |
We recently moved the registration of named writeables to pull approach. The task status named writeables were left out of this refactoring and should be migrated as well. As a result, transport client doesn't see the
BulkByScrollTask.Status
as its registration happens inNetworkModule
after the transport client pulled all the named writeables during its initialization.I guess we want to create a TaskPlugin interface like we have done with SearchPlugin, ActionPlugin etc.
The text was updated successfully, but these errors were encountered: