Fix reindex with transport client #19997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dadoonet, the bulk of this reworks some changes you made because they didn't play well with the transport client. Can you have a look? |
|
Looks like @dadoonet can't review it for a while. So, anyone else want it? |
|
@elasticmachine, retest this |
|
Test failure is caused by the branch point, not the change itself. |
nik9000
force-pushed
the
reindex_cancel_transport
branch
from
0bdbb4d
to
5dc8618
Compare
Rebased. That should help. |
| import org.elasticsearch.test.transport.AssertingLocalTransport; | ||
| import org.elasticsearch.transport.Transport; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| import java.util.Collections; |
There was a problem hiding this comment.
No code was added to this test class, only removed, so is this added import necessary?
There was a problem hiding this comment.
Nevermind, I see, it was a remnant from the imports up top, just got shifted around
|
LGTM |
nik9000
force-pushed
the
reindex_cancel_transport
branch
from
5dc8618
to
3483352
Compare
The big change here is cleaning up the `TaskListResponse` so it doesn't have a breaky `toString` implementation. That was causing the reindex tests to break. Also removed `NetworkModule#registerTaskStatus` which is part of the Plugin API. Use `Plugin#getNamedWriteables` instead.
nik9000
force-pushed
the
reindex_cancel_transport
branch
from
3483352
to
fdd5061
Compare
|
Merged! Thanks @abeyad ! |
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reindex's status requests through the transport client and reworks
ListTasksResponseso itstoStringisn't breaky with the transport client.Reworks #19773
Closes #19979