-
Notifications
You must be signed in to change notification settings - Fork 24.6k
-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API: Allow to upsert, provide a doc and index it if the doc does not exists #2008
Comments
Wonderfull, great work! :-) |
Would it be possible to use this new "doc" as the document containing the updated fields without needing to use a script? Taking a quick look though the code it seems like it might be possible if we check that no "script" is set then pull the updated source back out of the new IndexRequest. I imagine as we need to get it as a map but it looks like we can only get bytes currently. Once we have the sources we can merge and index. |
The problem here is how to "merge" that new doc values into the updated doc? Simple fields can be overridden or appended, but what happens with array values and the like? we can decide that its a simple override and thats it. |
I think a simple override would be nice, more complex operations would be done using scripts. |
Yea I think a simple override would be fine (just like the partial update plugin). If someone needs something more advanced they can use a script like Paikan said. |
It would be nice to have conditional insert so that insert happens only if the record does not exist. |
Is Index with |
Yep it is. Thanks |
Are there any other values that op_type can take besides create? |
Here is a sample:
The text was updated successfully, but these errors were encountered: