Update API: Allow to upsert, provide a doc and index it if the doc does not exists #2008

Closed
kimchy opened this Issue Jun 7, 2012 · 9 comments

Projects

None yet

6 participants

@kimchy
Member
kimchy commented Jun 7, 2012

Here is a sample:

curl -XPUT localhost:9200/test

curl -XPOST 'localhost:9200/test/type1/1/_update' -d '{
    "script" : "ctx._source.counter += count",
    "params" : {
        "count" : 4
    },
    "upsert" : {
        "counter" : 0
    }
}'

curl -XGET localhost:9200/test/type1/1
@kimchy kimchy closed this in 9905eab Jun 8, 2012
@Phantazm
Phantazm commented Jun 9, 2012

Wonderfull, great work! :-)

@mattweber

Would it be possible to use this new "doc" as the document containing the updated fields without needing to use a script?

Taking a quick look though the code it seems like it might be possible if we check that no "script" is set then pull the updated source back out of the new IndexRequest. I imagine as we need to get it as a map but it looks like we can only get bytes currently. Once we have the sources we can merge and index.

@kimchy
Member
kimchy commented Jun 12, 2012

The problem here is how to "merge" that new doc values into the updated doc? Simple fields can be overridden or appended, but what happens with array values and the like? we can decide that its a simple override and thats it.

@Paikan
Paikan commented Jun 12, 2012

I think a simple override would be nice, more complex operations would be done using scripts.

@mattweber

Yea I think a simple override would be fine (just like the partial update plugin). If someone needs something more advanced they can use a script like Paikan said.

@JW200
JW200 commented Nov 6, 2012

It would be nice to have conditional insert so that insert happens only if the record does not exist.

@imotov
Member
imotov commented Nov 6, 2012

Is Index with op_type=create the functionality you are looking for?

@JW200
JW200 commented Nov 7, 2012

Yep it is. Thanks

@JW200
JW200 commented Nov 7, 2012

Are there any other values that op_type can take besides create?

@Hendler Hendler referenced this issue in pyelasticsearch/pyelasticsearch Apr 5, 2013
Closed

Upsert supported? #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment