Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-plugin list error response #20691

Closed
markwalkom opened this issue Sep 29, 2016 · 1 comment · Fixed by #23562
Closed

elasticsearch-plugin list error response #20691

markwalkom opened this issue Sep 29, 2016 · 1 comment · Fixed by #23562
Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement help wanted adoptme

Comments

@markwalkom
Copy link
Contributor

Running the 5.0.0 beta1;

# /usr/share/elasticsearch/bin/elasticsearch-plugin list
Exception in thread "main" java.lang.IllegalArgumentException: Plugin [x-pack] is incompatible with Elasticsearch [5.0.0-beta1]. Was designed for version [5.0.0-alpha5]
    at org.elasticsearch.plugins.PluginInfo.readFromProperties(PluginInfo.java:108)
    at org.elasticsearch.plugins.ListPluginsCommand.execute(ListPluginsCommand.java:63)
    at org.elasticsearch.cli.SettingCommand.execute(SettingCommand.java:54)
    at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:96)
    at org.elasticsearch.cli.MultiCommand.execute(MultiCommand.java:69)
    at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:96)
    at org.elasticsearch.cli.Command.main(Command.java:62)
    at org.elasticsearch.plugins.PluginCli.main(PluginCli.java:42)

We shouldn't generate a massive error like this.

Ideally we should just list the plugins and then highlight the incompatibility, like this;

# /usr/share/elasticsearch/bin/elasticsearch-plugin list
x-pack@5.0.0-beta1 - INCOMPATIBLE PLUGIN, PLEASE UPGRADE

But if not, then just having a plain text response like Plugin [PLUGINNAME] is incompatible with Elasticsearch [VERSIONNOW]. Was designed for version [VERSIONPAST] would be great.

This is what KB does after upgrading;

# /usr/share/kibana/bin/kibana-plugin list
timelion@5.0.0-alpha5
x-pack@5.0.0-alpha5-SNAPSHOT

At this point, I'd still need to upgrade, though it doesn't stacktrace and could have info on the incompatibilities to make things clear.

@markwalkom markwalkom added the :Core/Infra/Plugins Plugin API and infrastructure label Sep 29, 2016
@s1monw s1monw added the help wanted adoptme label Sep 29, 2016
@s1monw
Copy link
Contributor

s1monw commented Sep 29, 2016

I agree this feels wrong

rjernst added a commit to rjernst/elasticsearch that referenced this issue Mar 13, 2017
…ible

This commit catches the underlying failure when trying to list plugin
information when a plugin is incompatible with the current version of
elasticsearch. This could happen when elasticsearch is upgraded but old
plugins still exist. With this change, all plugins will be output,
instead of failing at the first out of date plugin.

closes elastic#20691
rjernst added a commit that referenced this issue Mar 21, 2017
…ible (#23562)

This commit catches the underlying failure when trying to list plugin
information when a plugin is incompatible with the current version of
elasticsearch. This could happen when elasticsearch is upgraded but old
plugins still exist. With this change, all plugins will be output,
instead of failing at the first out of date plugin.

closes #20691
rjernst added a commit that referenced this issue Mar 21, 2017
…ible (#23562)

This commit catches the underlying failure when trying to list plugin
information when a plugin is incompatible with the current version of
elasticsearch. This could happen when elasticsearch is upgraded but old
plugins still exist. With this change, all plugins will be output,
instead of failing at the first out of date plugin.

closes #20691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure >enhancement help wanted adoptme
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants