Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ScriptedQuery form being cached in the query cache #20763

Closed
s1monw opened this issue Oct 5, 2016 · 0 comments
Closed

Prevent ScriptedQuery form being cached in the query cache #20763

s1monw opened this issue Oct 5, 2016 · 0 comments
Assignees
@jpountz
Labels
blocker >bug v5.0.0

Comments

@s1monw
Copy link
Contributor

s1monw commented Oct 5, 2016

ScriptedQuery can't be cached today and we should prevent it from happening. We might be able to relax this when we have #20762 in but for now we should just not cache
@jpountz jpountz self-assigned this Oct 5, 2016
jpountz added a commit to jpountz/elasticsearch that referenced this issue Oct 7, 2016
@jpountz
Do not cache script queries.
efd2722 
The cache relies on the equals() method so we just need to make sure script
queries can never be equals, even to themselves in the case that a weight
is used to produce a Scorer on the same segment multiple times.

Closes elastic#20763
@jpountz jpountz mentioned this issue Oct 7, 2016
Merged
jpountz added a commit that referenced this issue Oct 11, 2016
@jpountz
Do not cache script queries. (#20799)
1914df7 
The cache relies on the equals() method so we just need to make sure script
queries can never be equals, even to themselves in the case that a weight
is used to produce a Scorer on the same segment multiple times.

Closes #20763
jpountz added a commit that referenced this issue Oct 11, 2016
@jpountz
Do not cache script queries. (#20799)
e9c9cdf 
The cache relies on the equals() method so we just need to make sure script
queries can never be equals, even to themselves in the case that a weight
is used to produce a Scorer on the same segment multiple times.

Closes #20763
jpountz added a commit that referenced this issue Oct 11, 2016
@jpountz
Do not cache script queries. (#20799)
0bdea10 
The cache relies on the equals() method so we just need to make sure script
queries can never be equals, even to themselves in the case that a weight
is used to produce a Scorer on the same segment multiple times.

Closes #20763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpountz jpountz

Labels
blocker >bug v5.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpountz @s1monw