Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search context is not cleaned when scroll search is cancelled #21126

Closed
imotov opened this issue Oct 26, 2016 · 3 comments · Fixed by #21397
Closed

Search context is not cleaned when scroll search is cancelled #21126

imotov opened this issue Oct 26, 2016 · 3 comments · Fixed by #21397
Assignees
Labels
>bug :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. :Search/Search Search-related issues that do not fall into other categories

Comments

@imotov
Copy link
Contributor

imotov commented Oct 26, 2016

Cancelling search with scroll can leave some search contexts behind. See test failure in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=ubuntu/160/console

@imotov imotov added >bug :Search/Search Search-related issues that do not fall into other categories :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. labels Oct 26, 2016
@imotov imotov self-assigned this Oct 26, 2016
@nik9000
Copy link
Member

nik9000 commented Oct 31, 2016

😢

@imotov imotov added the stalled label Oct 31, 2016
@imotov
Copy link
Contributor Author

imotov commented Nov 1, 2016

I think I found the reason for the failure in these tests, but we need changes from #20767 to properly fix it.

@nik9000
Copy link
Member

nik9000 commented Nov 1, 2016

I'll get to it! I've got something so close to ready for review that I'd like to finish off first then I'll address your comments in #20767.

@imotov imotov removed the stalled label Nov 8, 2016
imotov added a commit to imotov/elasticsearch that referenced this issue Nov 11, 2016
…cancellation request before returning

Currently the task cancellation command returns as soon as the top-level parent child is marked as cancelled. This create race conditions in tests where child tasks on other nodes may continue to run for some time after the main task is cancelled. This commit fixes this situation making task cancellation command to wait until it got propagated to all nodes that have child tasks.

Closes elastic#21126
imotov added a commit that referenced this issue Nov 11, 2016
…cancellation request before returning

Currently the task cancellation command returns as soon as the top-level parent child is marked as cancelled. This create race conditions in tests where child tasks on other nodes may continue to run for some time after the main task is cancelled. This commit fixes this situation making task cancellation command to wait until it got propagated to all nodes that have child tasks.

Closes #21126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
2 participants