Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Tika 1.14 #21591

Merged
merged 1 commit into from Nov 18, 2016
Merged

Update to Tika 1.14 #21591

merged 1 commit into from Nov 18, 2016

Conversation

dadoonet
Copy link
Member

This PR will go to master branch.
Once merged I will either:

  • Push the changes as is to 5.x branch
  • Also update to Tika 1.14 for mapper-attachment plugin which is still living in 5.x series but deprecated.

I think I should do the later and update both plugins. What do you think?

Closes #20390.

@dadoonet dadoonet self-assigned this Nov 16, 2016
@dadoonet
Copy link
Member Author

retest this please

martijnvg
martijnvg approved these changes Nov 17, 2016
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg
Copy link
Member

I think I should do the later and update both plugins. What do you think?

I think updating both plugins make sense. (would be weird if two plugins depend on a different Tika version)

@dadoonet dadoonet merged commit 7517c50 into elastic:master Nov 18, 2016
@dadoonet dadoonet deleted the pr/update-tika-1.14 branch November 18, 2016 11:52
@dadoonet
Copy link
Member Author

Pushed to master. I'll come soonish with a PR for 5.x branch for both projects.
I saw that we also need to merge a similar update that we did in #20710 for mapper attachments in 5.x branch.

dadoonet added a commit to dadoonet/elasticsearch that referenced this pull request Nov 18, 2016
@dadoonet
Update to Tika 1.14
37b9752 
Related to elastic#21591 for mapper attachments plugin in 5.x branch
Also backported elastic#20710 for mapper attachments plugin in 5.x branch
@dadoonet dadoonet mentioned this pull request Nov 18, 2016
Merged
@clintongormley clintongormley added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP and removed :Plugin Ingest Attachment labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees

@dadoonet dadoonet

Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >upgrade v6.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dadoonet @martijnvg @clintongormley