Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document comments in Painless #23372

Closed
ycombinator opened this issue Feb 25, 2017 · 5 comments
Closed

Document comments in Painless #23372

ycombinator opened this issue Feb 25, 2017 · 5 comments
Assignees
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes

Comments

@ycombinator
Copy link
Contributor

ycombinator commented Feb 25, 2017

Painless apparently supports // ... and /* ... */ style comments. This is useful when writing out long, complex scripts.

It would be great to have this feature documented in https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-painless.html and/or https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-painless-syntax.html.

Thanks!

@nik9000
Copy link
Member

nik9000 commented Feb 27, 2017

@jdconrad is this a thing you are covering in your docs work? Should I assign this to you so you can close that when it is in?

@jdconrad jdconrad self-assigned this Feb 27, 2017
@jdconrad
Copy link
Contributor

@nik9000 I assigned to myself as this will be included in my updated documentation.

@nik9000
Copy link
Member

nik9000 commented Feb 27, 2017

@nik9000 I assigned to myself as this will be included in my updated documentation.

Thanks!

@drawsmcgraw
Copy link

Hi @jdconrad! I've submitted #24550 to help take this off your list. Hopefully I inferred the documentation style correctly. I'm happy to make any requested changes.

@clintongormley clintongormley added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache and removed :Plugin Lang Painless labels Feb 14, 2018
@jdconrad
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes
Projects
None yet
Development

No branches or pull requests

5 participants