-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleLocalTransportTests#testConcurrentSendRespondAndDisconnect failure #23942
Labels
:Distributed/Network
Http and internode communication implementations
>test
Issues or PRs that are addressing/adding tests
Comments
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this issue
Apr 7, 2017
…onnected There is a very small race that can cause requests to hang if nodes are concurrently disconnected while a connection is fetched form the transport and the client handler is installed in the TransportService. The code relies on the fact that closed connections either fully work or fail and cause the requests to be ended / finished with an exception. This is not necessarily true in local transport since it doesn't really maintain connections in the classical sense. This change adds additional checking for disconnected nodes when the connection is used to ensure the conneciton is never used with a disconnected transport. Closes elastic#23942
s1monw
added a commit
that referenced
this issue
Apr 7, 2017
…onnected (#23962) There is a very small race that can cause requests to hang if nodes are concurrently disconnected while a connection is fetched form the transport and the client handler is installed in the TransportService. The code relies on the fact that closed connections either fully work or fail and cause the requests to be ended / finished with an exception. This is not necessarily true in local transport since it doesn't really maintain connections in the classical sense. This change adds additional checking for disconnected nodes when the connection is used to ensure the connection is never used with a disconnected transport. Closes #23942
s1monw
added a commit
that referenced
this issue
Apr 7, 2017
…onnected (#23962) There is a very small race that can cause requests to hang if nodes are concurrently disconnected while a connection is fetched form the transport and the client handler is installed in the TransportService. The code relies on the fact that closed connections either fully work or fail and cause the requests to be ended / finished with an exception. This is not necessarily true in local transport since it doesn't really maintain connections in the classical sense. This change adds additional checking for disconnected nodes when the connection is used to ensure the connection is never used with a disconnected transport. Closes #23942
s1monw
added a commit
that referenced
this issue
Apr 7, 2017
…onnected (#23962) There is a very small race that can cause requests to hang if nodes are concurrently disconnected while a connection is fetched form the transport and the client handler is installed in the TransportService. The code relies on the fact that closed connections either fully work or fail and cause the requests to be ended / finished with an exception. This is not necessarily true in local transport since it doesn't really maintain connections in the classical sense. This change adds additional checking for disconnected nodes when the connection is used to ensure the connection is never used with a disconnected transport. Closes #23942
Fixed by ae1158c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Network
Http and internode communication implementations
>test
Issues or PRs that are addressing/adding tests
Fails because of a suite timeout and doesn't reproduce.
Build url: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+5.3+multijob-unix-compatibility/os=fedora/104
The text was updated successfully, but these errors were encountered: