Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Failure in SuggestStatsIT testSimpleStats #28543

Closed
cbuescher opened this issue Feb 7, 2018 · 1 comment
Closed

[CI] Failure in SuggestStatsIT testSimpleStats #28543

cbuescher opened this issue Feb 7, 2018 · 1 comment
Assignees
@cbuescher
Labels
:Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v7.0.0-beta1

Comments

@cbuescher
Copy link
Member

Link: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=centos/2018/console

00:24:36 FAILURE 4.45s J1 | SuggestStatsIT.testSimpleStats <<< FAILURES!
00:24:36    > Throwable #1: java.lang.AssertionError: 
00:24:36    > Expected: a value greater than <0L>
00:24:36    >      but: <0L> was equal to <0L>
00:24:36    > 	at __randomizedtesting.SeedInfo.seed([FDC21049ED079812:B806696314BB0DE2]:0)
00:24:36    > 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
00:24:36    > 	at org.elasticsearch.index.suggest.stats.SuggestStatsIT.testSimpleStats(SuggestStatsIT.java:127)
00:24:36    > 	at java.lang.Thread.run(Thread.java:748)

Doesn't reproduce locally for me so far with:

./gradlew :server:integTest -Dtests.seed=FDC21049ED079812 -Dtests.class=org.elasticsearch.index.suggest.stats.SuggestStatsIT -Dtests.method="testSimpleStats" -Dtests.security.manager=true -Dtests.locale=ar-BH -Dtests.timezone=Australia/Eucla
@cbuescher cbuescher added >test Issues or PRs that are addressing/adding tests :Search Relevance/Suggesters "Did you mean" and suggestions as you type >test-failure Triaged test failures from CI v7.0.0 labels Feb 7, 2018
@cbuescher cbuescher self-assigned this Feb 7, 2018
@cbuescher
Copy link
Member Author

cbuescher commented Feb 7, 2018 •
edited
Loading

The particular assertion tripping here is checking assertThat(suggestStats.getSuggestTimeInMillis(), greaterThan(0L)). When I run this test on a somewhat bigger machine locally I cannot get it to fail but I get close to execution times as low as 5-7ms, so I think it is entirely possible that on faster machines this might occasionally get rounded to 0ms. I think we can relax the assertion to greaterThanOrEqualTo(0L). I will check if there are other similar occurances in this integration test and open a PR.

cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT
74e09c4 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes elastic#28543
@cbuescher cbuescher mentioned this issue Feb 7, 2018
Merged
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
c0886cf 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
7d83fd5 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
7299dc3 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
f8b6e1b 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
5692e8f 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
cbuescher pushed a commit that referenced this issue Feb 7, 2018
[Tests] Relax assertion in SuggestStatsIT (#28544)
c5d48f7 
The test expects suggest times in milliseconds that are strictly
positive. Internally they are measured in nanos, it is possible that on
really fast execution this is rounded to 0L, so this should also be an
accepted value.

Closes #28543
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
:Search Relevance/Suggesters "Did you mean" and suggestions as you type Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colings86 @javanna @cbuescher