-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to privilege names in roles API #29703
Labels
Comments
Original comment by @tvernum: This is still an issue in 6.2
Is considered to be a valid role. |
Also, we need to add debug log here and similar other places where required. |
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this issue
Sep 5, 2019
This commit adds validation so a role cannot be created with invalid index or cluster privilege name. Closes elastic#29703
bizybot
added a commit
that referenced
this issue
Sep 24, 2019
This commit adds validation so a role cannot be created with invalid index or cluster privilege name. Closes #29703
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this issue
Sep 25, 2019
…tic#46361) This commit adds validation so a role cannot be created with invalid index or cluster privilege name. Closes elastic#29703
bizybot
added a commit
that referenced
this issue
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original comment by @ppf2:
I have a feeling that we may already have this on the roadmap and it's just not in the first iteration of the API. Filing to track progress since this will likely come up in the future. Currently, there is no validation on the values of the privileges set when creating roles. So it's possible for users to have a typo on the privilege names and the role will still get added/accepted by the API.
It will be nice if we can validate this and throw back and exception (or maybe even include the list of allowable values for privileges in the exception, etc..).
The text was updated successfully, but these errors were encountered: