Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] QueryStringQueryBuilderTests fails occasionally #32234

Closed
cbuescher opened this issue Jul 20, 2018 · 1 comment
Closed

[Test] QueryStringQueryBuilderTests fails occasionally #32234

cbuescher opened this issue Jul 20, 2018 · 1 comment
Assignees
@cbuescher
Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI

Comments

@cbuescher
Copy link
Member

Just found this while running tests locally. This tests fails reproducibly with the given seed:

./gradlew :server:test \
  -Dtests.seed=3BB9F91BD6345C6C \
  -Dtests.class=org.elasticsearch.index.query.QueryStringQueryBuilderTests

I think I already see the problem and will open a PR with a fix soon.
@cbuescher cbuescher added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Jul 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher cbuescher self-assigned this Jul 20, 2018
@cbuescher cbuescher mentioned this issue Jul 20, 2018
Merged
cbuescher pushed a commit that referenced this issue Jul 20, 2018
[Tests] Remove QueryStringQueryBuilderTests#toQuery class assertions (#…
54d896c 
…32236)

Currently we check that the queries that QueryStringQueryBuilder#toQuery returns
is one out of a list of many Lucene query classes. This list has extended a lot over time,
since QueryStringQueryBuilder can build all sort of queries. This makes the test hard to 
maintain. The recent addition of alias fields which build a BlendedTermQuery show how
easy this test breaks. Also the current assertions doesn't add a lot in terms of catching
errors. This is why we decided to remove this check.

Closes #32234
cbuescher pushed a commit that referenced this issue Jul 20, 2018
[Tests] Remove QueryStringQueryBuilderTests#toQuery class assertions (#…
4c2f2ef 
…32236)

Currently we check that the queries that QueryStringQueryBuilder#toQuery returns
is one out of a list of many Lucene query classes. This list has extended a lot over time,
since QueryStringQueryBuilder can build all sort of queries. This makes the test hard to
maintain. The recent addition of alias fields which build a BlendedTermQuery show how
easy this test breaks. Also the current assertions doesn't add a lot in terms of catching
errors. This is why we decided to remove this check.

Closes #32234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
:Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbuescher @elasticmachine