Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic Search high level client not encoding + symbol properly in Get Request #33077

Closed
vikaslinux opened this issue Aug 23, 2018 · 1 comment · Fixed by #33164
Closed

Elastic Search high level client not encoding + symbol properly in Get Request #33077

vikaslinux opened this issue Aug 23, 2018 · 1 comment · Fixed by #33164
Assignees
Labels

Comments

@vikaslinux
Copy link

vikaslinux commented Aug 23, 2018

Elasticsearch version (bin/elasticsearch --version): 6.3.0

Plugins installed: [Kibana, Cerebro]

JVM version (java -version): 1.8

OS version (uname -a if on a Unix-like system): Linux kernel 4.9.93-0.1 #1 SMP Thu Jun 21 13:50:19 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Description of the problem including expected versus actual behavior:

Steps to reproduce:
Use rest high level client and

where document id is any document id which contains "+" symbol.
GetRequest getRequest = new GetRequest(index, type, documentId);

    GetResponse getResponse = restHighLevelClient.get(getRequest);

Please include a minimal but complete recreation of the problem, including
(e.g.) index creation, mappings, settings, query etc. The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

  1. Create any index and any type
  2. Index a document with document id that contains "+"
  3. Search with the above provided code
  4. You should not find the document with an id that includes "+"

Provide logs (if relevant):

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jpountz jpountz added the help wanted adoptme label Aug 23, 2018
@original-brownbear original-brownbear self-assigned this Aug 27, 2018
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Aug 27, 2018
* Encode `+` correctly as `%2B`
* Closes elastic#33077
pull bot pushed a commit to rogues-gallery/elasticsearch that referenced this issue Jul 15, 2019
* HLRC: Fix '+' Not Correctly Encoded in GET Req.

* Encode `+` correctly as `%2B` in URL paths
* Keep encoding `+` as space in URL parameters
* Closes elastic#33077
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jul 15, 2019
* HLRC: Fix '+' Not Correctly Encoded in GET Req.

* Encode `+` correctly as `%2B` in URL paths
* Keep encoding `+` as space in URL parameters
* Closes elastic#33077
original-brownbear added a commit that referenced this issue Jul 15, 2019
* HLRC: Fix '+' Not Correctly Encoded in GET Req.

* Encode `+` correctly as `%2B` in URL paths
* Keep encoding `+` as space in URL parameters
* Closes #33077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants