Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: inconsistency between error message for functions #33469

Closed
astefan opened this issue Sep 6, 2018 · 1 comment
Closed

SQL: inconsistency between error message for functions #33469

astefan opened this issue Sep 6, 2018 · 1 comment

Comments

@astefan
Copy link
Contributor

astefan commented Sep 6, 2018

Some functions differ in error messages from others. For example INSERT doesn't mention which parameter should be of a certain type, while REPEAT does:

sql> select insert('aaa','bbb',1,2);
Bad request [Found 1 problem(s)
line 1:8: 'INSERT' requires a numeric type, received keyword]
sql> select repeat(1,2);
Bad request [Found 1 problem(s)
line 1:8: 'REPEAT' requires first parameter to be a string type, received INTEGER]
@astefan astefan self-assigned this Sep 6, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@matriv matriv assigned matriv and unassigned astefan Oct 26, 2018
matriv added a commit to matriv/elasticsearch that referenced this issue Oct 26, 2018
Extract data type verification for function arguments to a single place
so that NULL type can be treated as RESOLVED for all functions. Moreover
this enables to have consistent verification error messages for all functions.

Fixes: elastic#34752
Fixes: elastic#33469
@matriv matriv added the v6.5.1 label Oct 26, 2018
matriv pushed a commit that referenced this issue Oct 29, 2018
Extract data type verification for function arguments to a single place
so that NULL type can be treated as RESOLVED for all functions. Moreover
this enables to have consistent verification error messages for all functions.

Fixes: #34752
Fixes: #33469
matriv pushed a commit that referenced this issue Oct 29, 2018
Extract data type verification for function arguments to a single place
so that NULL type can be treated as RESOLVED for all functions. Moreover
this enables to have consistent verification error messages for all functions.

Fixes: #34752
Fixes: #33469
matriv pushed a commit that referenced this issue Oct 29, 2018
Extract data type verification for function arguments to a single place
so that NULL type can be treated as RESOLVED for all functions. Moreover
this enables to have consistent verification error messages for all functions.

Fixes: #34752
Fixes: #33469
kcm pushed a commit that referenced this issue Oct 30, 2018
Extract data type verification for function arguments to a single place
so that NULL type can be treated as RESOLVED for all functions. Moreover
this enables to have consistent verification error messages for all functions.

Fixes: #34752
Fixes: #33469
@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 2, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants