Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Move internals away from Joda to java.time #35633

Closed
costin opened this issue Nov 16, 2018 · 1 comment
Closed

SQL: Move internals away from Joda to java.time #35633

costin opened this issue Nov 16, 2018 · 1 comment
Labels
:Analytics/SQL SQL querying >enhancement v6.6.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Nov 16, 2018

Internally SQL relies on a mix of java.time and joda classes which are confusing and sometimes unexpected.
This becomes even more of an issue when dealing with date time math, as the input and output need to confirm to one API.
While the Joda dependency might not be removed all-together until #27330, we can limit its use and make the transition smoother when the time comes.

relates to #27330
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

costin added a commit to costin/elasticsearch that referenced this issue Nov 16, 2018
@costin
SQL: Move internals from Joda to java.time
1d99f7b 
Try to remove usage of Joda through-out the processors and functions
Use ZonedDateTime wherever possible instead of long/tzId

Fix elastic#35633
@costin costin mentioned this issue Nov 16, 2018
Merged
costin added a commit that referenced this issue Nov 17, 2018
@costin
SQL: Move internals from Joda to java.time (#35649)
f8e333b 
Remove/Limit usage of Joda through-out the processors and functions
Use ZonedDateTime wherever possible instead of long/tzId

Fix #35633
costin added a commit that referenced this issue Nov 17, 2018
@costin
SQL: Move internals from Joda to java.time (#35649)
fea332c 
Remove/Limit usage of Joda through-out the processors and functions
Use ZonedDateTime wherever possible instead of long/tzId

Fix #35633

(cherry picked from commit f8e333b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @colings86 @elasticmachine