Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Improve validation of unsupported fields #35673

Closed
costin opened this issue Nov 17, 2018 · 1 comment
Closed

SQL: Improve validation of unsupported fields #35673

costin opened this issue Nov 17, 2018 · 1 comment
Labels
:Analytics/SQL SQL querying >enhancement v6.5.2 v6.6.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Nov 17, 2018

Given the query

SELECT * FROM test WHERE xxx > 1

the verifier will not correctly pick up that xxx is an unsupported field and will let the query processing apply. While this eventually fails it should not happen.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

costin added a commit to costin/elasticsearch that referenced this issue Nov 17, 2018
@costin
SQL: Improve validation of unsupported fields
837db8c 
Fix bug in Analyzer that caused it to report unsupported fields only
 when declared in projections. The rule has been extended to all field
 declarations.

Fix elastic#35673
@costin costin added the v6.5.1 label Nov 17, 2018
@costin costin mentioned this issue Nov 17, 2018
Merged
costin added a commit that referenced this issue Nov 18, 2018
@costin
SQL: Improve validation of unsupported fields (#35675)
4119409 
Fix bug in Analyzer that caused it to report unsupported fields only
 when declared in projections. The rule has been extended to all field
 declarations.

Fix #35673
costin added a commit that referenced this issue Nov 18, 2018
@costin
SQL: Improve validation of unsupported fields (#35675)
971f354 
Fix bug in Analyzer that caused it to report unsupported fields only
 when declared in projections. The rule has been extended to all field
 declarations.

Fix #35673

(cherry picked from commit 4119409)
costin added a commit that referenced this issue Nov 18, 2018
@costin
SQL: Improve validation of unsupported fields (#35675)
57516e9 
Fix bug in Analyzer that caused it to report unsupported fields only
 when declared in projections. The rule has been extended to all field
 declarations.

Fix #35673

(cherry picked from commit 4119409)
@lcawl lcawl added v6.5.2 and removed v6.5.1 labels Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.2 v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@costin @colings86 @elasticmachine @lcawl