New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FrozenIndexTests.testCloseFreezeAndOpen fails on master #35785
Comments
Pinging @elastic/es-distributed |
@s1monw would you like to have a look at this? I haven't muted the test as it failed only once since it was added. Let me know how you prefer to proceed? |
Another hit:
|
We looked at this failure during test triage power hour. In the beginning we thought this might be due to the response being returned after only one of the shards returned data from the fetch phase, which is always the case since this is paginating with a size of 1. But now that I'm looking deeper I'm afraid this can't explain this test failure. Our gut feeling was that this is is a race condition, ie. the response is returned before the reader had a chance to be closed but we would like to be sure before turning the assertion into an assertBusy. |
Acquiring a searcher is unnecessary to determin if a refresh is necessary since read-only engines never refresh. Closes elastic#35785
@jpountz I opened #35837 - the issue is that we concurrently hold the reader to check if a refresh is needed. I was able to reproduce it with a tight loop around the scroll. So it's kind of a test bug to I fixed it in code since the refreshNeeded call is unnecessary. |
Acquiring a searcher is unnecessary to determine if a refresh is necessary since read-only engines never refresh. Closes #35785
Acquiring a searcher is unnecessary to determine if a refresh is necessary since read-only engines never refresh. Closes #35785
Failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+intake/266/console
The assertion that fails is at
assertFalse(((FrozenEngine) engine).isReaderOpen());
Reproduce line (does not reproduce for me):
The text was updated successfully, but these errors were encountered: