Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typeless index call can fail against an index with a custom type. #36811

Closed
jtibshirani opened this issue Dec 19, 2018 · 4 comments
Closed

Typeless index call can fail against an index with a custom type. #36811

jtibshirani opened this issue Dec 19, 2018 · 4 comments
Assignees
@jpountz
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Dec 19, 2018 •
edited
Loading

Using the typeless index APIs can result in an error when the index contains a custom type name that is not _doc. The issue seems to arise when the index call introduces a mapping update.

The following gist demonstrates the problem: https://gist.github.com/jtibshirani/0929faf60bd78c794aeb01cc08d04c73.

The same issue also applies to typeless document update calls.
@jtibshirani jtibshirani added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0 labels Dec 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jtibshirani
Copy link
Contributor Author

jtibshirani commented Dec 19, 2018 •
edited
Loading

@jpountz would you be able to look at this issue, as a continuation of #35790?

CC @urso

@jpountz jpountz self-assigned this Dec 21, 2018
@benwtrent
Copy link
Member

I ran into this same issue when calling a typeless _reindex against an index that had dynamically created fields.

Recreation steps: https://gist.github.com/benwtrent/2e3ea1e87746f58f557898869fd95e77

@jtibshirani jtibshirani mentioned this issue Jan 4, 2019
Closed
48 tasks
@jpountz
Copy link
Contributor

jpountz commented Jan 10, 2019

@jtibshirani Absolutely, I'm putting it on top of my TODO list.

jtibshirani added a commit to jtibshirani/elasticsearch that referenced this issue Jan 15, 2019
@jtibshirani
Make sure to use the resolved type in DocumentMapperService#extractMa…
eaae24c 
…ppings.

* Pull out a shared method MapperService#resolveDocumentType.
* Make sure to resolve the type when extracting the mappings.

Addresses elastic#36811.
@jtibshirani jtibshirani mentioned this issue Jan 15, 2019
Merged
jtibshirani added a commit that referenced this issue Jan 15, 2019
@jtibshirani
Make sure to use the resolved type in DocumentMapperService#extractMa…
1a1dbf7 
…ppings. (#37451)

* Pull out a shared method MapperService#resolveDocumentType.
* Make sure to resolve the type when extracting the mappings.

Addresses #36811.
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpountz jpountz

Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jpountz @benwtrent @jtibshirani @elasticmachine @jimczi