New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Make `FULL` non reserved keyword in the grammar #37376

Closed
matriv opened this Issue Jan 11, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@matriv
Copy link
Contributor

matriv commented Jan 11, 2019

This issue was revealed by doing tests for #37128.
Trying to execute select full.* from test doesn't work since full is a reserved keyword in the ANTLR4 grammar.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Jan 11, 2019

matriv added a commit to matriv/elasticsearch that referenced this issue Jan 11, 2019

SQL: Make `FULL` non-reserved keyword in the grammar
Since `full` can be common as a field name or part of a field name
(e.g.: `full.name` or `name.full`), it's nice if it's not a reserved
keyword of the grammar so a user can use it without resorting to quotes.

Fixes: elastic#37376

@matriv matriv self-assigned this Jan 11, 2019

matriv added a commit that referenced this issue Jan 11, 2019

SQL: Make `FULL` non-reserved keyword in the grammar (#37377)
Since `full` can be common as a field name or part of a field name
(e.g.: `full.name` or `name.full`), it's nice if it's not a reserved
keyword of the grammar so a user can use it without resorting to quotes.

Fixes: #37376

matriv added a commit that referenced this issue Jan 11, 2019

SQL: Make `FULL` non-reserved keyword in the grammar (#37377)
Since `full` can be common as a field name or part of a field name
(e.g.: `full.name` or `name.full`), it's nice if it's not a reserved
keyword of the grammar so a user can use it without resorting to quotes.

Fixes: #37376

matriv added a commit that referenced this issue Jan 11, 2019

SQL: Make `FULL` non-reserved keyword in the grammar (#37377)
Since `full` can be common as a field name or part of a field name
(e.g.: `full.name` or `name.full`), it's nice if it's not a reserved
keyword of the grammar so a user can use it without resorting to quotes.

Fixes: #37376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment