Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testClientSucceedsWithVerificationDisabled fails on master #38212

Closed
dnhatn opened this issue Feb 1, 2019 · 4 comments · Fixed by #38214
Closed

testClientSucceedsWithVerificationDisabled fails on master #38212

dnhatn opened this issue Feb 1, 2019 · 4 comments · Fixed by #38214
Assignees
@tvernum
Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Feb 1, 2019

testClientSucceedsWithVerificationDisabled fails on FipsJVM. I think we expect this test not to run on FipsJVM but mistakenly use assertFalse instead of assumeFalse.

CI:

 ./gradlew :modules:reindex:unitTest \
  -Dtests.seed=3868B83F74B6BE50 \
  -Dtests.class=org.elasticsearch.index.reindex.ReindexRestClientSslTests \
  -Dtests.method="testClientSucceedsWithVerificationDisabled" \
  -Dtests.security.manager=true \
  -Dtests.locale=da \
  -Dtests.timezone=Africa/Asmera \
  -Dcompiler.java=12 \
  -Druntime.java=8FIPS \
  -Djavax.net.ssl.keyStorePassword=password \
  -Djavax.net.ssl.trustStorePassword=password
@dnhatn dnhatn added >test-failure Triaged test failures from CI :Security/Security Security issues without another label labels Feb 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

dnhatn added a commit to dnhatn/elasticsearch that referenced this issue Feb 1, 2019
@dnhatn
AwaitsFix testClientSucceedsWithVerificationDisabled
376f202 
Tracked at elastic#38212
@dnhatn dnhatn mentioned this issue Feb 1, 2019
Merged
@jkakavas
Copy link
Member

jkakavas commented Feb 1, 2019

That's correct Nhat, I will fix and update this as it's already weekend for Tim

@dnhatn
Copy link
Member Author

dnhatn commented Feb 1, 2019

Thanks @jkakavas :)

dnhatn added a commit that referenced this issue Feb 1, 2019
@dnhatn
AwaitsFix testClientSucceedsWithVerificationDisabled (#38213)
7023583 
Tracked at #38212
jkakavas added a commit to jkakavas/elasticsearch that referenced this issue Feb 1, 2019
@jkakavas
Correctly disable tests for FIPS JVMs
86a66ce 
Replace assertFalse with assumeFalse

Resolves: elastic#38212
@jkakavas jkakavas mentioned this issue Feb 1, 2019
Merged
jkakavas added a commit that referenced this issue Feb 1, 2019
@jkakavas
Correctly disable tests for FIPS JVMs (#38214)
78a65c3 
Replace assertFalse with assumeFalse

Resolves: #38212
talevy added a commit to talevy/elasticsearch that referenced this issue Feb 13, 2019
@talevy
Correctly disable tests for FIPS JVMs
007aed2 
Replace assertFalse with assumeFalse

resolves elastic#38212.

backport of elastic#38214.
@talevy talevy mentioned this issue Feb 13, 2019
Merged
@talevy
Copy link
Contributor

talevy commented Feb 13, 2019

opened #38871 to backport this fix to 6.7

talevy added a commit that referenced this issue Feb 14, 2019
@talevy
Correctly disable tests for FIPS JVMs (#38871)
5ab2479 
Replace assertFalse with assumeFalse

resolves #38212.

backport of #38214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvernum tvernum

Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly disable tests for FIPS JVMs jkakavas/elasticsearch
5 participants
@talevy @tvernum @jkakavas @dnhatn @elasticmachine