Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLConfigurationReloaderTests hangs when run locally #38247

Closed
gwbrown opened this issue Feb 2, 2019 · 1 comment · Fixed by #38341
Closed

SSLConfigurationReloaderTests hangs when run locally #38247

gwbrown opened this issue Feb 2, 2019 · 1 comment · Fixed by #38341
Assignees
@jaymode
Labels
:Security/TLS SSL/TLS, Certificates >test-failure Triaged test failures from CI

Comments

@gwbrown
Copy link
Contributor

gwbrown commented Feb 2, 2019 •
edited
Loading

This test suite hangs indefinitely when run locally, but I haven't seen CI be impacted yet.

Reproduce with:

./gradlew :x-pack:plugin:core:test \
  -Dtests.seed=5DB61DD425F081B \
  -Dtests.class=org.elasticsearch.xpack.core.ssl.SSLConfigurationReloaderTests \
  -Dtests.security.manager=true \
  -Dtests.locale=en-US \
  -Dtests.timezone=Etc/UTC

Whichever test runs first in this suite hangs.
Upon further investigation, only testReloadingTrustStore and testReloadingPEMTrustConfig hang.

Possibly related to #32124

Appears to have been introduced by #38103

Confirmed on MacOS and Linux.
@gwbrown gwbrown added >test-failure Triaged test failures from CI :Security/TLS SSL/TLS, Certificates labels Feb 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@gwbrown gwbrown mentioned this issue Feb 2, 2019
Merged
jaymode added a commit to jaymode/elasticsearch that referenced this issue Feb 4, 2019
@jaymode
Fix SSLContext pinning to TLSV1.2 in reload tests
3c87937 
This commit fixes the pinning of SSLContexts to TLSv1.2 in the
SSLConfigurationReloaderTests. The pinning was added for the initial
creation of clients and webservers but the updated contexts would
default to TLSv1.3, which is known to cause hangs with the
MockWebServer that we use.

Relates elastic#38103
Closes elastic#38247
@jaymode jaymode mentioned this issue Feb 4, 2019
Merged
jaymode added a commit that referenced this issue Feb 4, 2019
@jaymode
Fix SSLContext pinning to TLSV1.2 in reload tests (#38341)
c3cdf84 
This commit fixes the pinning of SSLContexts to TLSv1.2 in the
SSLConfigurationReloaderTests. The pinning was added for the initial
creation of clients and webservers but the updated contexts would
default to TLSv1.3, which is known to cause hangs with the
MockWebServer that we use.

Relates #38103
Closes #38247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaymode jaymode

Labels
:Security/TLS SSL/TLS, Certificates >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SSLContext pinning to TLSV1.2 in reload tests jaymode/elasticsearch
3 participants
@gwbrown @jaymode @elasticmachine