Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Don't serialize ZonedDateTime value directly in scripts #39877

Closed
costin opened this issue Mar 9, 2019 · 1 comment · Fixed by #39911
Closed

SQL: Don't serialize ZonedDateTime value directly in scripts #39877

costin opened this issue Mar 9, 2019 · 1 comment · Fixed by #39911
Labels
:Analytics/SQL SQL querying >bug v6.6.3 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1

Comments

@costin
Copy link
Member

costin commented Mar 9, 2019

While Painless scripts do accept ZonedDateTime objects, serializing this into scripts (for example through the translate API) doesn't work since they get rendered as strings instead of actual objects.
As such, we should wrap them in dedicated methods to construct the runtime ZonedDateTime from primitives (such as strings).
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

costin added a commit to costin/elasticsearch that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts
af989d9 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix elastic#39877
@costin costin mentioned this issue Mar 11, 2019
Merged
costin added a commit to costin/elasticsearch that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts
371ef7e 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix elastic#39877
costin added a commit that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts (#39911)
4957cad 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix #39877
costin added a commit that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts (#39911)
92a87a4 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix #39877

(cherry picked from commit 4957cad)
costin added a commit that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts (#39911)
be350d5 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix #39877

(cherry picked from commit 4957cad)
costin added a commit that referenced this issue Mar 11, 2019
@costin
SQL: Wrap ZonedDateTime parameters inside scripts (#39911)
e075a23 
Painless allows ZonedDateTime objects to be passed natively to scripts
which creates problematic translate queries as the ZonedDateTime is
passed as a string instead.
Wrap this with a dedicated method to perform the conversion.

Fix #39877

(cherry picked from commit 4957cad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v6.6.3 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Wrap ZonedDateTime parameters inside scripts costin/elasticsearch
3 participants
@costin @jakelandis @elasticmachine