Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: JDBC always uses timezone=UTC for requests to server #39915

Closed
matriv opened this issue Mar 11, 2019 · 1 comment · Fixed by #39978
Closed

SQL: JDBC always uses timezone=UTC for requests to server #39915

matriv opened this issue Mar 11, 2019 · 1 comment · Fixed by #39978
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >bug

Comments

@matriv
Copy link
Contributor

matriv commented Mar 11, 2019

JDBC always uses UTC as the timezone param for requests sent to the server,
regardless of the ?timezone=XXX used in the connection string.

This is a bug, as all calculations with date/times (eg. scalar functions applies on top of them like DAY_OF_MONTH) are done with UTC timezone, and they potentially give wrong results, and those
operations cannot be translated and fixed in the client JDBC (which still holds the correct timezone passed from the params), as the original information of the exact timestamp is lost.
@matriv matriv added >bug :Analytics/SQL SQL querying labels Mar 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@matriv matriv self-assigned this Mar 11, 2019
matriv added a commit to matriv/elasticsearch that referenced this issue Mar 12, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type
1eb4ff2 
Previously, JDBC's REST call to the server was always sending `UTC`
instead of the timezone passed through connection string/properties.

Moreover the conversion to `java.sql.Date` was problematic as a
milliseconds calculation on the epoch millis was used to set the time
to 00:00:00.000 and the timezone info was lost. This caused the resuling
`java.sql.Date` object which is always using the JVM's timezone (no
matter what timezone setting is used in the connection
string/properties) to be wrongly created.

Fixes: elastic#39915
@matriv matriv mentioned this issue Mar 12, 2019
Merged
matriv added a commit that referenced this issue Mar 14, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type (#39978)
60cbecc 
Previously, JDBC's REST call to the server was always sending UTC
instead of the timezone passed through connection string/properties.

Moreover the conversion to java.sql.Date was problematic as a
calculation on the epoch millis was used to set the time to 00:00:00.000
and the timezone info was lost. This caused the resulting java.sql.Date
object which is always using the JVM's timezone (no matter what timezone
setting is used in the connection string/properties) to be wrongly created.

Fixes: #39915
matriv added a commit that referenced this issue Mar 14, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type (#39978)
4e9657f 
Previously, JDBC's REST call to the server was always sending UTC
instead of the timezone passed through connection string/properties.

Moreover the conversion to java.sql.Date was problematic as a
calculation on the epoch millis was used to set the time to 00:00:00.000
and the timezone info was lost. This caused the resulting java.sql.Date
object which is always using the JVM's timezone (no matter what timezone
setting is used in the connection string/properties) to be wrongly created.

Fixes: #39915
matriv added a commit that referenced this issue Mar 14, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type (#39978)
3c74a31 
Previously, JDBC's REST call to the server was always sending UTC
instead of the timezone passed through connection string/properties.

Moreover the conversion to java.sql.Date was problematic as a
calculation on the epoch millis was used to set the time to 00:00:00.000
and the timezone info was lost. This caused the resulting java.sql.Date
object which is always using the JVM's timezone (no matter what timezone
setting is used in the connection string/properties) to be wrongly created.

Fixes: #39915
matriv added a commit that referenced this issue Mar 14, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type (#39978)
cfda2c0 
Previously, JDBC's REST call to the server was always sending UTC
instead of the timezone passed through connection string/properties.

Moreover the conversion to java.sql.Date was problematic as a
calculation on the epoch millis was used to set the time to 00:00:00.000
and the timezone info was lost. This caused the resulting java.sql.Date
object which is always using the JVM's timezone (no matter what timezone
setting is used in the connection string/properties) to be wrongly created.

Fixes: #39915
matriv added a commit that referenced this issue Mar 14, 2019
@matriv
SQL: Fix bug with JDBC timezone setting and DATE type (#39978)
7611210 
Previously, JDBC's REST call to the server was always sending UTC
instead of the timezone passed through connection string/properties.

Moreover the conversion to java.sql.Date was problematic as a
calculation on the epoch millis was used to set the time to 00:00:00.000
and the timezone info was lost. This caused the resulting java.sql.Date
object which is always using the JVM's timezone (no matter what timezone
setting is used in the connection string/properties) to be wrongly created.

Fixes: #39915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Fix bug with JDBC timezone setting and DATE type matriv/elasticsearch
2 participants
@matriv @elasticmachine