-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoFollowIT#testCleanFollowedLeaderIndexUUIDs failures #41071
Comments
Pinging @elastic/es-distributed |
This looks to be a transport issue. Can you have a look @tbrooks8 ? Recent failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.1+multijob-darwin-compatibility/10/consoleFull Relevant log line:
|
Similar issue #41071. |
Another instance https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.1+multijob-darwin-compatibility/15/consoleText.
|
@tbrooks8 can you have a look? |
My best guess is that this is similar to this: envoyproxy/envoy#1446 |
@tbrooks8 interesting find. How do you think we should fix this? Should we just log a warning on OS X and move on? Could we possibly delay setting the option until we're fully connected? |
We could delay setting the socket options until connection is complete. That would require a little reworking how how things are now. Possibly just add a connection complete future to set them. I'll think about it submit a PR sometime this week. |
Brings some temporary relief for test failures until #41071 is addressed.
Brings some temporary relief for test failures until #41071 is addressed.
Currently in the transport-nio work we connect and bind channels on the a thread before the channel is registered with a selector. Additionally, it is at this point that we set all the socket options. This commit moves these operations onto the event-loop after the channel has been registered with a selector. It attempts to set the socket options for a non-server channel at registration time. If that fails, it will attempt to set the options after the channel is connected. This should fix #41071.
Currently in the transport-nio work we connect and bind channels on the a thread before the channel is registered with a selector. Additionally, it is at this point that we set all the socket options. This commit moves these operations onto the event-loop after the channel has been registered with a selector. It attempts to set the socket options for a non-server channel at registration time. If that fails, it will attempt to set the options after the channel is connected. This should fix elastic#41071.
Currently in the transport-nio work we connect and bind channels on the a thread before the channel is registered with a selector. Additionally, it is at this point that we set all the socket options. This commit moves these operations onto the event-loop after the channel has been registered with a selector. It attempts to set the socket options for a non-server channel at registration time. If that fails, it will attempt to set the options after the channel is connected. This should fix #41071.
On 7.x: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-darwin-compatibility/99/console
Could not reproduce locally on 7.x:
Stacktraces:
The text was updated successfully, but these errors were encountered: