Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path-style S3 access is deprecated #41816

Closed
DaveCTurner opened this issue May 4, 2019 · 5 comments · Fixed by #41966
Closed

Path-style S3 access is deprecated #41816

DaveCTurner opened this issue May 4, 2019 · 5 comments · Fixed by #41966
Assignees
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs

Comments

@DaveCTurner
Copy link
Contributor

It was recently announced that path-style access to S3 is deprecated will be rejected by S3 starting 2020-09-30. However, since #34721 (i.e. 7.0), the repository-s3 plugin exclusively uses path-style access, to make it easier to use Minio-backed repositories. This needs a re-think.

@DaveCTurner DaveCTurner added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs team-discuss labels May 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@messense
Copy link

messense commented May 6, 2019

Hitting this issue with Alibaba Cloud OSS service (S3 like service), it only supports virtual host style access.

@original-brownbear
Copy link
Member

IMO, as nice as it was to get rid of this config option, we should simply add back the setting to choose between path and DNS style access.
I don't think we can determine the correct access pattern on the fly in a stable way and it's not that hard to make the correct choice of setting as a user with a little documentation on the compatibility of this anyway.

@messense
Copy link

messense commented May 6, 2019

Adding the config option back would be great. Thanks!

@original-brownbear
Copy link
Member

We discussed this during today's team sync. The fact that AWS will stop supporting the path style access pattern makes the solution build in #34721 not viable long term.

I will open a PR (to go into 7.2+) shortly that adds back the option to choose path style access and default it to false and add documentation of this breaking change accordingly.

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue May 8, 2019
* As discussed, added the option to use path style access back again and
deprecated it.
* Defaulted to `false`
* Added warning to docs

* Closes elastic#41816
original-brownbear added a commit that referenced this issue Jul 4, 2019
* Provide an Option to Use Path-Style-Access with S3 Repo

* As discussed, added the option to use path style access back again and
deprecated it.
* Defaulted to `false`
* Added warning to docs

* Closes #41816
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Jul 7, 2019
* Provide an Option to Use Path-Style-Access with S3 Repo

* As discussed, added the option to use path style access back again and
deprecated it.
* Defaulted to `false`
* Added warning to docs

* Closes elastic#41816
original-brownbear added a commit that referenced this issue Jul 8, 2019
)

* Provide an Option to Use Path-Style-Access with S3 Repo

* As discussed, added the option to use path style access back again and
deprecated it.
* Defaulted to `false`
* Added warning to docs

* Closes #41816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants