Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Agg integration tests with AggregatorTestCase #42893

Open
5 of 46 tasks
polyfractal opened this issue Jun 5, 2019 · 1 comment
Open
5 of 46 tasks

Replace Agg integration tests with AggregatorTestCase #42893

polyfractal opened this issue Jun 5, 2019 · 1 comment
Labels
:Analytics/Aggregations Aggregations Meta >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt >test Issues or PRs that are addressing/adding tests

Comments

@polyfractal
Copy link
Contributor

polyfractal commented Jun 5, 2019 •
edited by csoulios

Similar in spirit to #36015, but with the goal of removing unecessary metric/bucket agg IT. Unlike the pipeline aggs, it should be very straightforward to replace, and I think we can probably remove most of the existing ESIntegTestCase tests

Some of these aggs do already have an AggregatorTestCase, so we should evaluate if the IT has something the unit test does not, migrate if possible and decide if the IT is useful otherwise.

A quick skim shows a lot of the IT deal with scripts, unmapped fields, formatting, etc. It's not clear to me right now if we can test some of these (notably scripts) outside of an IT. So that might be a reason to keep the IT around.

Metrics

Bucket

  • StringTermsIT
  • AdjacencyMatrixIT
  • BooleanTermsIT
  • DateHistogramIT
  • DateHistogramOffsetIT
  • DateRangeIT
  • DiversifiedSamplerIT
  • DoubleTermsIT
  • FilterIT
  • FiltersIT
  • GeoDistanceIT
  • GeoHashGridIT
  • GeoDistanceIT
  • GlobalIT
  • HistogramIT
  • IpRangeIT
  • IpTermsIT
  • LongTermsIT
  • MinDocCountIT
  • MissingIT (migrate tests from MissingIT to MissingAggregatorTests #53448)
  • NaNSortingIT
  • RangeIT
  • ReverseNestedIT
  • SamplerIT
  • ShardREduceIT
  • ShardSizeTermsIT
  • SignificantTermsSignificanceScoreIT
  • NestedIT
  • TermsDocCountErrorIT
  • TermsShardMinDocCountIT
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@polyfractal polyfractal mentioned this issue Jun 5, 2019
Closed
@polyfractal polyfractal added the >test Issues or PRs that are addressing/adding tests label Jun 5, 2019
This was referenced Jun 21, 2019
Merged
Merged
@csoulios csoulios mentioned this issue Jul 8, 2019
Merged
csoulios added a commit that referenced this issue Jul 10, 2019
@csoulios
Migrating tests from AvgIT integration test to AvgAggregatorTests (#4…
b8bf351 
…4076)

This PR migrates most tests from AvgIT integration test to AvgAggregatorTests, as described in #42893
csoulios added a commit to csoulios/elasticsearch that referenced this issue Jul 11, 2019
@csoulios
Migrating tests from AvgIT integration test to AvgAggregatorTests (el…
6f14e75 
…astic#44076)

This PR migrates most tests from AvgIT integration test to AvgAggregatorTests, as described in elastic#42893
@csoulios csoulios mentioned this issue Jul 11, 2019
Merged
csoulios added a commit that referenced this issue Jul 11, 2019
@csoulios
Migrating tests from AvgIT integration test to AvgAggregatorTests (#4…
c091b6c 
…4076) (#44225)

This PR migrates most tests from AvgIT integration test to AvgAggregatorTests, as described in #42893
@csoulios csoulios mentioned this issue Jul 31, 2019
Merged
csoulios added a commit that referenced this issue Aug 20, 2019
@csoulios
Migrate tests from MaxIT to MaxAggregatorTests (#45030)
09d8384 
This PR migrates tests from MaxIT integration test to MaxAggregatorTests, as described in #42893
csoulios added a commit to csoulios/elasticsearch that referenced this issue Aug 20, 2019
@csoulios
Migrate tests from MaxIT to MaxAggregatorTests (elastic#45030)
49cb460 
This PR migrates tests from MaxIT integration test to MaxAggregatorTests, as described in elastic#42893
@csoulios csoulios mentioned this issue Aug 20, 2019
Merged
csoulios added a commit that referenced this issue Aug 20, 2019
@csoulios
[7.x] Migrate tests from MaxIT to MaxAggregatorTests (#45030) #45742
96a40ac 
Backports PR #45030 to 7.x:

    This PR migrates tests from MaxIT integration test to MaxAggregatorTests, as described in #42893
@polyfractal polyfractal mentioned this issue Dec 10, 2019
Merged
This was referenced Jan 17, 2020
Merged
Open
andyb-elastic added a commit to andyb-elastic/elasticsearch that referenced this issue Mar 12, 2020
@andyb-elastic
migrate missing agg tests
476c87e 
Move the remaining tests for the missing aggregation into its
AggregatorTestCase out of its integration test and remove the IT

For elastic#42893
@andyb-elastic andyb-elastic mentioned this issue Mar 12, 2020
Merged
@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@csoulios csoulios mentioned this issue Apr 7, 2021
Closed
@salvatore-campagna salvatore-campagna mentioned this issue Nov 23, 2021
Merged
salvatore-campagna added a commit that referenced this issue Dec 1, 2021
@salvatore-campagna
Migrate CardinalityIT test to CardinalityAggregatorTests (#80951)
1acfc92 
This PR migrates tests from CardinalityIT integration tests to CardinalityAggregatorTests, as described in #42893
@wchaparro wchaparro added the Meta label Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations Meta >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @polyfractal @wchaparro @elasticmachine