Enable node roles to be pluggable #43175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the possibility for a plugin to introduce additional node roles.
jasontedor
added
>enhancement
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra |
jasontedor
commented
Jun 13, 2019
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
rjernst
reviewed
Jun 13, 2019
server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodes.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/node/DiscoveryNode.java
Outdated
Show resolved
Hide resolved
|
@rjernst I pushed. |
jasontedor
added a commit
that referenced
this pull request
Jun 13, 2019
This commit introduces the possibility for a plugin to introduce additional node roles.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 14, 2019
The test fails if querying the roles via a transport client, since the transport client does not have the plugin necessary to interpret the additional role correctly. This commit adds this plugin to the transport client used. Relates elastic#43175 Fixes elastic#43223
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 14, 2019
Adds methods to `DiscoveryNodeRole.UnknownRole` to compare these objects' values for equality, and adds a specialized `toString()` implementation for clearer test failures. Relates elastic#43175
DaveCTurner
added a commit
that referenced
this pull request
Jun 14, 2019
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 15, 2019
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare these objects' values for equality, and adds a field to allow us to distinguish unknown roles from known ones with the same name and abbreviation, for clearer test failures. Relates elastic#43175
pull bot
pushed a commit
to rogues-gallery/elasticsearch
that referenced
this pull request
Jun 17, 2019
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare these objects' values for equality, and adds a field to allow us to distinguish unknown roles from known ones with the same name and abbreviation, for clearer test failures. Relates elastic#43175
DaveCTurner
added a commit
that referenced
this pull request
Jun 17, 2019
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare these objects' values for equality, and adds a field to allow us to distinguish unknown roles from known ones with the same name and abbreviation, for clearer test failures. Relates #43175
jkakavas
pushed a commit
to jkakavas/elasticsearch
that referenced
this pull request
Jun 27, 2019
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare these objects' values for equality, and adds a field to allow us to distinguish unknown roles from known ones with the same name and abbreviation, for clearer test failures. Relates elastic#43175
lukas-vlcek
added a commit
to vvanholl/elasticsearch-prometheus-exporter
that referenced
this pull request
Aug 13, 2019
There are two main changes impacting the code when upgrading top 7.3.0. The first is introduction of pluggable Node roles: - elastic/elasticsearch#43175 The second is renaming the Action class to ActionType: - elastic/elasticsearch#43778
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the possibility for a plugin to introduce additional node roles.