Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ml/data_frame/analytics/_estimate_memory_usage API endpoint #45188

Merged
merged 11 commits into from
Aug 13, 2019

Conversation

przemekwitek
Copy link
Contributor

This PR introduces ml/data_frame/analytics/_estimate_memory_usage API endpoint that will be used to obtain memory usage estimation even before the analysis gets started.

Relates #44699

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this - I know it's a lot of changes for what seems like it should be simple functionality.

I just left a few minor comments and questions.

@droberts195
Copy link
Contributor

Jenkins run elasticsearch-ci/1

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the CI is passing

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/2

@droberts195 droberts195 removed the :ml/Transform Transform label Aug 13, 2019
@droberts195 droberts195 added :ml Machine learning >enhancement labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants