HLRC for memory usage estimation API #45531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
memory_estimation_hlrc
branch
from
bf58e18
to
d199e33
Compare
przemekwitek
force-pushed
the
memory_estimation_hlrc
branch
from
d199e33
to
f2d65e6
Compare
|
Pinging @elastic/ml-core |
|
run elasticsearch-ci/2 |
1 similar comment
|
run elasticsearch-ci/2 |
6 tasks
|
run elasticsearch-ci/2 |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Aug 14, 2019
przemekwitek
added a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements HLRC for memory usage estimation API introduced in #45188.
Additionally, it makes DataFrameAnalyticsConfig constructor not check for arguments being not-null. This is needed so that memory usage estimation request can be passed without "id" and "dest". For PUT requests, non-nullity of required fields is still validated by the server.
Relates #44699