-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLRC for memory usage estimation API #45531
Merged
przemekwitek
merged 1 commit into
elastic:master
from
przemekwitek:memory_estimation_hlrc
Aug 14, 2019
Merged
HLRC for memory usage estimation API #45531
przemekwitek
merged 1 commit into
elastic:master
from
przemekwitek:memory_estimation_hlrc
Aug 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf58e18
to
d199e33
Compare
d199e33
to
f2d65e6
Compare
Pinging @elastic/ml-core |
droberts195
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run elasticsearch-ci/2 |
1 similar comment
run elasticsearch-ci/2 |
6 tasks
run elasticsearch-ci/2 |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Aug 14, 2019
przemekwitek
added a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements HLRC for memory usage estimation API introduced in #45188.
Additionally, it makes DataFrameAnalyticsConfig constructor not check for arguments being not-null. This is needed so that memory usage estimation request can be passed without "id" and "dest". For PUT requests, non-nullity of required fields is still validated by the server.
Relates #44699