Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search with Terms lookup might get stuck while doing a get for the terms #4519

Closed
kimchy opened this issue Dec 19, 2013 · 2 comments
Closed

Search with Terms lookup might get stuck while doing a get for the terms #4519

kimchy opened this issue Dec 19, 2013 · 2 comments
Labels
>bug v0.90.9 v1.0.0.RC1

Comments

@kimchy
Copy link
Member

kimchy commented Dec 19, 2013

Have seem it in the field, it seems to be stuck on getting the doc. Might be because of execution a failed search on the network worker thread (which is wrong, should be on the search thread pool). Also, we need to introduce a timeout so at least it won't get stuck on the get operation.
@kimchy kimchy mentioned this issue Dec 19, 2013
Closed
kimchy added a commit that referenced this issue Dec 19, 2013
@kimchy
Failed search on a shard tries a local replica on a network thread
5bf4e74 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain #4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes #4526

note, re-enable the geo shape fetch test, this fix should solve it as well
kimchy added a commit that referenced this issue Dec 19, 2013
@kimchy
Failed search on a shard tries a local replica on a network thread
a230a7f 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain #4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes #4526

note, re-enable the geo shape fetch test, this fix should solve it as well
kimchy added a commit that referenced this issue Dec 19, 2013
@kimchy
Failed search on a shard tries a local replica on a network thread
e349774 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain #4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes #4526

note, re-enable the geo shape fetch test, this fix should solve it as well
@kimchy
Copy link
Member Author

kimchy commented Dec 23, 2013

Seems to be fixed thanks to #4526, a search that used to fail due to it (geo shape fetching) has been re-enabled and has not failed...

@kimchy kimchy closed this as completed Dec 23, 2013
@lmenezes
Copy link
Contributor

👍 will give it a try when possible and give you some feedback on that. thanks!

brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@kimchy @brusic
Failed search on a shard tries a local replica on a network thread
1d7ce08 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain elastic#4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes elastic#4526

note, re-enable the geo shape fetch test, this fix should solve it as well
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
Failed search on a shard tries a local replica on a network thread
14f1c04 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain elastic#4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes elastic#4526

note, re-enable the geo shape fetch test, this fix should solve it as well
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
Failed search on a shard tries a local replica on a network thread
b50c3ee 
When a search on a shard to a remove node fails, and then replica exists on the local node, then the execution of the search is done on the network thread. This is problematic since we need to execute it on the actual search thread pool, but can also explain elastic#4519, where the get happens on the network thread and it waits to send the get request till the network thread we use is freed (deadlock...)
fixes elastic#4526

note, re-enable the geo shape fetch test, this fix should solve it as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug v0.90.9 v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @lmenezes