Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: High Rest Client MultiSearchTemplateRequest ignores HTTP-GET parameters #46488

Closed
eemelianov opened this issue Sep 9, 2019 · 2 comments · Fixed by #46492
Closed

BUG: High Rest Client MultiSearchTemplateRequest ignores HTTP-GET parameters #46488

eemelianov opened this issue Sep 9, 2019 · 2 comments · Fixed by #46492
Assignees
@henningandersen
Labels
>bug

Comments

@eemelianov
Copy link

Elasticsearch version elastic Docker-Image elasticsearch:7.3.0
High Rest Client version 7.3.1

Plugins installed: []

Description of the problem including expected versus actual behavior:
Hight Rest Client maps es-requests to Low Level Rest Client Requests. MultiSearchTemplateRequest is mapped via RequestConverters#multiSearchTemplate, this method is missing the line to add Params to the underlying Request, like in other methods: request.addParameters(params.asMap());

Steps to reproduce:

  1. Create a MultiSearchTemplateRequest add a request and use a stored script with simple terms aggregation.
  2. Use RestHighLevelClient#msearchTemplate(request, RequestOptions.DEFAULT) to get the response.
@henningandersen henningandersen self-assigned this Sep 9, 2019
henningandersen added a commit to henningandersen/elasticsearch that referenced this issue Sep 9, 2019
@henningandersen
HLRC multisearchTemplate forgot params
ea3afb8 
Since 7.3, the request converter for multiSearchTemplate would silently
not set the two request parameters `types_keys` and
`max_concurrent_searches`.

Closes elastic#46488
@henningandersen henningandersen mentioned this issue Sep 9, 2019
Merged
@henningandersen
Copy link
Contributor

@eemelianov , thanks for reporting this, I opened #46492 to fix this.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

henningandersen added a commit that referenced this issue Sep 10, 2019
@henningandersen
HLRC multisearchTemplate forgot params (#46492)
043f1d4 
Since 7.3, the request converter for multiSearchTemplate would silently
not set the two request parameters `typed_keys` and
`max_concurrent_searches`.

Closes #46488
henningandersen added a commit that referenced this issue Sep 10, 2019
@henningandersen
HLRC multisearchTemplate forgot params (#46492)
7125c10 
Since 7.3, the request converter for multiSearchTemplate would silently
not set the two request parameters `typed_keys` and
`max_concurrent_searches`.

Closes #46488
henningandersen added a commit that referenced this issue Sep 10, 2019
@henningandersen
HLRC multisearchTemplate forgot params (#46492)
d83807f 
Since 7.3, the request converter for multiSearchTemplate would silently
not set the two request parameters `typed_keys` and
`max_concurrent_searches`.

Closes #46488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henningandersen henningandersen

Labels
>bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HLRC multisearchTemplate forgot params henningandersen/elasticsearch
3 participants
@eemelianov @elasticmachine @henningandersen