-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: High Rest Client MultiSearchTemplateRequest ignores HTTP-GET parameters #46488
Labels
Comments
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this issue
Sep 9, 2019
Since 7.3, the request converter for multiSearchTemplate would silently not set the two request parameters `types_keys` and `max_concurrent_searches`. Closes elastic#46488
@eemelianov , thanks for reporting this, I opened #46492 to fix this. |
Pinging @elastic/es-core-features |
henningandersen
added a commit
that referenced
this issue
Sep 10, 2019
Since 7.3, the request converter for multiSearchTemplate would silently not set the two request parameters `typed_keys` and `max_concurrent_searches`. Closes #46488
henningandersen
added a commit
that referenced
this issue
Sep 10, 2019
Since 7.3, the request converter for multiSearchTemplate would silently not set the two request parameters `typed_keys` and `max_concurrent_searches`. Closes #46488
henningandersen
added a commit
that referenced
this issue
Sep 10, 2019
Since 7.3, the request converter for multiSearchTemplate would silently not set the two request parameters `typed_keys` and `max_concurrent_searches`. Closes #46488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Elasticsearch version elastic Docker-Image elasticsearch:7.3.0
High Rest Client version 7.3.1
Plugins installed: []
Description of the problem including expected versus actual behavior:
Hight Rest Client maps es-requests to Low Level Rest Client Requests. MultiSearchTemplateRequest is mapped via RequestConverters#multiSearchTemplate, this method is missing the line to add Params to the underlying Request, like in other methods:
request.addParameters(params.asMap());
Steps to reproduce:
The text was updated successfully, but these errors were encountered: