Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunTask should pass settings from system properties starting with test.es. #47797

Closed
alpar-t opened this issue Oct 9, 2019 · 1 comment · Fixed by #47860
Closed

RunTask should pass settings from system properties starting with test.es. #47797

alpar-t opened this issue Oct 9, 2019 · 1 comment · Fixed by #47860
Assignees
@alpar-t
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@alpar-t
Copy link
Contributor

alpar-t commented Oct 9, 2019

As we replaced the RunTask with one that works with testclusters we lost the possibility of adding setting from the command line.

While -Drun.license=trial can still be used to change the license, one has no way for instance to run off security.
@alpar-t alpar-t added the :Delivery/Build Build or test infrastructure label Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@alpar-t alpar-t self-assigned this Oct 10, 2019
alpar-t added a commit to alpar-t/elasticsearch that referenced this issue Oct 10, 2019
@alpar-t
Make the run task honor tests.es properties
78b26ef 
Closes elastic#47797

With this PR we now again honor tests.es and tests.heap.size
@alpar-t alpar-t mentioned this issue Oct 10, 2019
Merged
alpar-t added a commit that referenced this issue Oct 11, 2019
@alpar-t
Make the run task honor tests.es properties (#47860)
95a3da2 
* Make the run task honor tests.es properties

Closes #47797

With this PR we now again honor tests.es and tests.heap.size

* remove debuging
alpar-t added a commit that referenced this issue Oct 11, 2019
@alpar-t
Make the run task honor tests.es properties (#47860)
ec91fa5 
* Make the run task honor tests.es properties

Closes #47797

With this PR we now again honor tests.es and tests.heap.size

* remove debuging
howardhuanghua pushed a commit to TencentCloudES/elasticsearch that referenced this issue Oct 14, 2019
@alpar-t @howardhuanghua
Make the run task honor tests.es properties (elastic#47860)
3a4c6d7 
* Make the run task honor tests.es properties

Closes elastic#47797

With this PR we now again honor tests.es and tests.heap.size

* remove debuging
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpar-t alpar-t

Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the run task honor tests.es properties alpar-t/elasticsearch
3 participants
@alpar-t @mark-vieira @elasticmachine