Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Painless: Create API to determine available languages for a context #49463

Closed
stu-elastic opened this issue Nov 21, 2019 · 1 comment · Fixed by #49652
Closed

Painless: Create API to determine available languages for a context #49463

stu-elastic opened this issue Nov 21, 2019 · 1 comment · Fixed by #49652
Assignees
@stu-elastic
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v7.6.0 v8.0.0-alpha1

Comments

@stu-elastic
Copy link
Contributor

stu-elastic commented Nov 21, 2019 •
edited
Loading

Ref: elastic/kibana#11959

Kibana needs to know which languages are available for a given context. That used to be available by calling: http://localhost:9200/_cluster/settings?include_defaults=true&filter_path=**.script.engine.*.inline

A couple of wrinkles:

  1. Determining whether scripts are available as stored and/or inline is a per-node setting, so hitting different nodes may return different results.
  2. The script contexts supported per ScriptEngine is not defined in a current API. For this we may add a method to ScriptEngine which returns supported contexts. If we add a method to the ScriptEngine interface, it's a breaking change.
  3. Different contexts maybe be available for OSS and Basic licenses.

cc: @rjernst @jdconrad
@stu-elastic stu-elastic added >enhancement :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 v7.6.0 labels Nov 21, 2019
@stu-elastic stu-elastic self-assigned this Nov 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

stu-elastic added a commit to stu-elastic/elasticsearch that referenced this issue Nov 27, 2019
@stu-elastic
Scripting: add available languages & contexts API
5b5e617 
Adds `GET /_script_language` to support Kibana dynamic scripting
language selection.

Response contains whether `inline` and/or `stored` scripts are
enabled as determined by the `script.allowed_types` settings.

For each scripting language registered, such as `painless`,
`expression`, `mustache` or custom, available contexts for the language
are included as determined by the `script.allowed_contexts` setting.

Response format:
```
{
  "types_allowed": [
    "inline",
    "stored"
  ],
  "language_contexts": [
    {
      "language": "expression",
      "contexts": [
        "aggregation_selector",
        "aggs"
        ...
      ]
    },
    {
      "language": "painless",
      "contexts": [
        "aggregation_selector",
        "aggs",
        "aggs_combine",
        ...
      ]
    }
...
  ]
}
```

Fixes: elastic#49463
@stu-elastic stu-elastic mentioned this issue Nov 27, 2019
Merged
stu-elastic added a commit that referenced this issue Dec 4, 2019
@stu-elastic
Scripting: add available languages & contexts API (#49652)
4a07802 
Adds `GET /_script_language` to support Kibana dynamic scripting
language selection.

Response contains whether `inline` and/or `stored` scripts are
enabled as determined by the `script.allowed_types` settings.

For each scripting language registered, such as `painless`,
`expression`, `mustache` or custom, available contexts for the language
are included as determined by the `script.allowed_contexts` setting.

Response format:
```
{
  "types_allowed": [
    "inline",
    "stored"
  ],
  "language_contexts": [
    {
      "language": "expression",
      "contexts": [
        "aggregation_selector",
        "aggs"
        ...
      ]
    },
    {
      "language": "painless",
      "contexts": [
        "aggregation_selector",
        "aggs",
        "aggs_combine",
        ...
      ]
    }
...
  ]
}
```

Fixes: #49463
stu-elastic added a commit to stu-elastic/elasticsearch that referenced this issue Dec 4, 2019
@stu-elastic
Scripting: add available languages & contexts API (elastic#49652)
5884b6d 
Adds `GET /_script_language` to support Kibana dynamic scripting
language selection.

Response contains whether `inline` and/or `stored` scripts are
enabled as determined by the `script.allowed_types` settings.

For each scripting language registered, such as `painless`,
`expression`, `mustache` or custom, available contexts for the language
are included as determined by the `script.allowed_contexts` setting.

Response format:
```
{
  "types_allowed": [
    "inline",
    "stored"
  ],
  "language_contexts": [
    {
      "language": "expression",
      "contexts": [
        "aggregation_selector",
        "aggs"
        ...
      ]
    },
    {
      "language": "painless",
      "contexts": [
        "aggregation_selector",
        "aggs",
        "aggs_combine",
        ...
      ]
    }
...
  ]
}
```

Fixes: elastic#49463
@stu-elastic stu-elastic mentioned this issue Dec 4, 2019
Merged
stu-elastic added a commit that referenced this issue Dec 4, 2019
@stu-elastic
Scripting: add available languages & contexts API (#49652) (#49815)
426c7a5 
Adds `GET /_script_language` to support Kibana dynamic scripting
language selection.

Response contains whether `inline` and/or `stored` scripts are
enabled as determined by the `script.allowed_types` settings.

For each scripting language registered, such as `painless`,
`expression`, `mustache` or custom, available contexts for the language
are included as determined by the `script.allowed_contexts` setting.

Response format:
```
{
  "types_allowed": [
    "inline",
    "stored"
  ],
  "language_contexts": [
    {
      "language": "expression",
      "contexts": [
        "aggregation_selector",
        "aggs"
        ...
      ]
    },
    {
      "language": "painless",
      "contexts": [
        "aggregation_selector",
        "aggs",
        "aggs_combine",
        ...
      ]
    }
...
  ]
}
```

Fixes: #49463 

**Backport**
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@stu-elastic @SivagurunathanV
Scripting: add available languages & contexts API (elastic#49652)
f4368c3 
Adds `GET /_script_language` to support Kibana dynamic scripting
language selection.

Response contains whether `inline` and/or `stored` scripts are
enabled as determined by the `script.allowed_types` settings.

For each scripting language registered, such as `painless`,
`expression`, `mustache` or custom, available contexts for the language
are included as determined by the `script.allowed_contexts` setting.

Response format:
```
{
  "types_allowed": [
    "inline",
    "stored"
  ],
  "language_contexts": [
    {
      "language": "expression",
      "contexts": [
        "aggregation_selector",
        "aggs"
        ...
      ]
    },
    {
      "language": "painless",
      "contexts": [
        "aggregation_selector",
        "aggs",
        "aggs_combine",
        ...
      ]
    }
...
  ]
}
```

Fixes: elastic#49463
This was referenced Feb 3, 2020
Closed
Closed
@mattkime mattkime mentioned this issue Mar 31, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stu-elastic stu-elastic

Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scripting: add available languages & contexts API stu-elastic/elasticsearch
3 participants
@jakelandis @elasticmachine @stu-elastic