Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] InternalGeoBoundsTests.testFromXContentWithRandomFields failure #50505

Closed
andreidan opened this issue Dec 27, 2019 · 3 comments · Fixed by #50506
Closed

[CI] InternalGeoBoundsTests.testFromXContentWithRandomFields failure #50505

andreidan opened this issue Dec 27, 2019 · 3 comments · Fixed by #50506
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI

Comments

@andreidan
Copy link
Contributor

Failure:

java.lang.NullPointerException
	at __randomizedtesting.SeedInfo.seed([1C33F4DADA278134:1E26D99B81E009E1]:0)
	at org.elasticsearch.search.aggregations.metrics.ParsedGeoBounds.topLeft(ParsedGeoBounds.java:58)
	at org.elasticsearch.search.aggregations.metrics.InternalGeoBoundsTests.assertFromXContent(InternalGeoBoundsTests.java:100)
	at org.elasticsearch.search.aggregations.metrics.InternalGeoBoundsTests.assertFromXContent(InternalGeoBoundsTests.java:36)
	at org.elasticsearch.test.InternalAggregationTestCase.testFromXContentWithRandomFields(InternalAggregationTestCase.java:356)

Branch master and 7.6.0

Reproduce with

./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.metrics.InternalGeoBoundsTests.testFromXContentWithRandomFields" \
  -Dtests.seed=1C33F4DADA278134 \
  -Dtests.security.manager=true \
  -Dtests.locale=ga-IE \
  -Dtests.timezone=Atlantic/Bermuda \
  -Dcompiler.java=13

Build scan available at https://gradle-enterprise.elastic.co/s/7x2ct6yywkw3o

This is a regression introduced by #50253
@andreidan andreidan added :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI labels Dec 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

andreidan added a commit to andreidan/elasticsearch that referenced this issue Dec 27, 2019
@andreidan
Guard against null geoBoundingBox
f020d9a 
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null `geoBoundingBox`. This commit marks the
field as `Nullable` and guards against null when retrieving the `topLeft`
and `bottomRight` fields.

Fixes elastic#50505
@andreidan andreidan mentioned this issue Dec 27, 2019
Merged
@ebadyano
Copy link
Contributor

ebadyano commented Jan 2, 2020

Another failure:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=openjdk13,ES_RUNTIME_JAVA=zulu11,nodes=general-purpose/425/console

@cbuescher
Copy link
Member

Another one today:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-darwin-compatibility/436/console
Build Scan: https://gradle-enterprise.elastic.co/s/wlgqig3gu635k
Tried the PR from 50506 which fixes it though.

andreidan added a commit that referenced this issue Jan 3, 2020
@andreidan
Guard against null geoBoundingBox (#50506)
051718f 
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null `geoBoundingBox`. This commit marks the
field as `Nullable` and guards against null when retrieving the `topLeft`
and `bottomRight` fields.

Fixes #50505
andreidan added a commit to andreidan/elasticsearch that referenced this issue Jan 3, 2020
@andreidan
Guard against null geoBoundingBox (elastic#50506)
95e0f96 
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null `geoBoundingBox`. This commit marks the
field as `Nullable` and guards against null when retrieving the `topLeft`
and `bottomRight` fields.

Fixes elastic#50505

(cherry picked from commit 051718f)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
@andreidan andreidan mentioned this issue Jan 3, 2020
Merged
andreidan added a commit that referenced this issue Jan 3, 2020
@andreidan
Guard against null geoBoundingBox (#50506) (#50608)
856607b 
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null `geoBoundingBox`. This commit marks the
field as `Nullable` and guards against null when retrieving the `topLeft`
and `bottomRight` fields.

Fixes #50505

(cherry picked from commit 051718f)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@andreidan @SivagurunathanV
Guard against null geoBoundingBox (elastic#50506)
160eea7 
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null `geoBoundingBox`. This commit marks the
field as `Nullable` and guards against null when retrieving the `topLeft`
and `bottomRight` fields.

Fixes elastic#50505
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Guard against null geoBoundingBox andreidan/elasticsearch
4 participants
@andreidan @cbuescher @elasticmachine @ebadyano