Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove camel-case nGram and edgeNGram tokenizers #50561

Closed
cbuescher opened this issue Jan 2, 2020 · 1 comment · Fixed by #50862
Closed

Deprecate and remove camel-case nGram and edgeNGram tokenizers #50561

cbuescher opened this issue Jan 2, 2020 · 1 comment · Fixed by #50862
Assignees
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v7.6.0 v8.0.0-alpha1

Comments

@cbuescher
Copy link
Member

We deprecated and removed the camel-case versions of the nGram and edgeNGram filters
a while ago (deprecation in 6, removal ongoing see #50376). I think we
should do the same with the nGram and edgeNGram tokenizers, deprecating the use of these naming variants
in favour of ngram and edge_ngram in 7, preventing newly created indices to use them starting with 8 and removal
in a future version where there can be no indices using them any longer.

@cbuescher cbuescher added :Search Relevance/Analysis How text is split into tokens v8.0.0 v7.6.0 labels Jan 2, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

@cbuescher cbuescher self-assigned this Jan 10, 2020
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Jan 10, 2020
We already deprecated and removed the camel-case versions of the nGram and edgeNGram filters
a while ago and we should do the same with the nGram and edgeNGram tokenizers.
This PR deprecates the use of these names in favour of ngram and edge_ngram in 7
and disallows usage in new indices starting with 8. The deprecation part will be
backported to 7.6.

Closes elastic#50561
cbuescher pushed a commit that referenced this issue Jan 14, 2020
We already deprecated and removed the camel-case versions of the nGram and edgeNGram 
filters a while ago and we should do the same with the nGram and edgeNGram tokenizers.
This PR deprecates the use of these names in favour of ngram and edge_ngram in 7
and disallows usage in new indices starting with 8.

Closes #50561
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Jan 14, 2020
…ic#50862)

We already deprecated and removed the camel-case versions of the nGram and edgeNGram
filters a while ago and we should do the same with the nGram and edgeNGram tokenizers.
This PR deprecates the use of these names in favour of ngram and edge_ngram in
7. Usage will be disallowed on new indices starting with 8 then.

Closes elastic#50561
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
…ic#50862)

We already deprecated and removed the camel-case versions of the nGram and edgeNGram 
filters a while ago and we should do the same with the nGram and edgeNGram tokenizers.
This PR deprecates the use of these names in favour of ngram and edge_ngram in 7
and disallows usage in new indices starting with 8.

Closes elastic#50561
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants