Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndicesOptions wilcard state parsing is too lenient #50762

Closed
jaymode opened this issue Jan 8, 2020 · 3 comments
Closed

IndicesOptions wilcard state parsing is too lenient #50762

jaymode opened this issue Jan 8, 2020 · 3 comments
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team

Comments

@jaymode
Copy link
Member

jaymode commented Jan 8, 2020

The logic to parse IndicesOptions.WildcardStates from a String or List of strings is overly lenient in that the ordering of values results in a different output when none is used as one of the values.

Input Output
all,none
none,all open, closed
none,open open
open,none
closed,none,open open

The parsing should be made more strict to disallow none with other values. There could be some users relying on this behavior, so to maintain BWC we could deprecate the use of none with other values in 7.x and disallow none with other values in 8.0.

@jaymode jaymode added :Data Management/Indices APIs APIs to create and manage indices and templates team-discuss labels Jan 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@jaymode jaymode mentioned this issue Jan 8, 2020
8 tasks
@martijnvg
Copy link
Member

+1 to remove the none with other leniency as is described in this issue.

@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@dakrone
Copy link
Member

dakrone commented May 17, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@dakrone dakrone closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team
Projects
None yet
Development

No branches or pull requests

6 participants