Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpCertificateCommandTests.testTextFileSubstitutions fails on Windows #50964

Closed
danielmitterdorfer opened this issue Jan 14, 2020 · 1 comment · Fixed by #51030
Closed

HttpCertificateCommandTests.testTextFileSubstitutions fails on Windows #50964

danielmitterdorfer opened this issue Jan 14, 2020 · 1 comment · Fixed by #51030
Assignees
@tvernum
Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI

Comments

@danielmitterdorfer
Copy link
Member

HttpCertificateCommandTests.testTextFileSubstitutions is failing on Windows with:

java.lang.AssertionError: 
Expected: is "abc\n"
     but: was "abc\r\n"

Reprocuction line:

gradlew ':x-pack:plugin:security:cli:test' --tests "org.elasticsearch.xpack.security.cli.HttpCertificateCommandTests.testTextFileSubstitutions" -Dtests.seed=49D93F9069E53A90 -Dtests.security.manager=true -Dtests.locale=und -Dtests.timezone=America/Barbados -Dcompiler.java=13

Reproduces always on Windows

Build link: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/os=windows-2012-r2/383/

Build scan: https://gradle-enterprise.elastic.co/s/ponnyxciguldy
@danielmitterdorfer danielmitterdorfer added >test-failure Triaged test failures from CI :Security/Security Security issues without another label labels Jan 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Security)

@danielmitterdorfer danielmitterdorfer mentioned this issue Jan 14, 2020
Merged
danielmitterdorfer added a commit that referenced this issue Jan 14, 2020
@danielmitterdorfer
Mute HttpCertificateCommandTests.testTextFileSubstitutions (#50965)
0439f57 
Relates #50964
@danielmitterdorfer danielmitterdorfer mentioned this issue Jan 14, 2020
Merged
danielmitterdorfer added a commit that referenced this issue Jan 14, 2020
@danielmitterdorfer
Mute HttpCertificateCommandTests.testTextFileSubstitutions (#50965) (#…
263083b 
…50966)

Relates #50964
tvernum added a commit to tvernum/elasticsearch that referenced this issue Jan 15, 2020
@tvernum
Fix newline issue in test
339178d 
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
@tvernum tvernum mentioned this issue Jan 15, 2020
Merged
tvernum added a commit that referenced this issue Jan 15, 2020
@tvernum
Fix windows newline issue in test (#51030)
c4c2314 
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: #50964
tvernum added a commit to tvernum/elasticsearch that referenced this issue Jan 16, 2020
@tvernum
Fix windows newline issue in test
a1a32bb 
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Backport of: elastic#51030
tvernum added a commit to tvernum/elasticsearch that referenced this issue Jan 16, 2020
@tvernum
Fix windows newline issue in test
556be07 
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Backport of: elastic#51030
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@danielmitterdorfer @SivagurunathanV
Mute HttpCertificateCommandTests.testTextFileSubstitutions (elastic#5…
1e3fdcf 
…0965)

Relates elastic#50964
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@tvernum @SivagurunathanV
Fix windows newline issue in test (elastic#51030)
70d3973 
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvernum tvernum

Labels
:Security/Security Security issues without another label >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix windows newline issue in test tvernum/elasticsearch
3 participants
@danielmitterdorfer @tvernum @elasticmachine