Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoGridAggregatorTestCase#hasBounds fails with non-empty agg assertion #51103

Closed
polyfractal opened this issue Jan 16, 2020 · 2 comments · Fixed by #51118
Closed

GeoGridAggregatorTestCase#hasBounds fails with non-empty agg assertion #51103

polyfractal opened this issue Jan 16, 2020 · 2 comments · Fixed by #51118
Assignees
@talevy
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI

Comments

@polyfractal
Copy link
Contributor

Reproduces for me locally, will push a mute for the tests.

Fails an assertion for the agg having a value:

assertTrue(AggregationInspectionHelper.hasValue(geoGrid));

./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.geogrid.GeoTileGridAggregatorTests.testBounds" -Dtests.seed=2B983432901303C6 -Dtests.security.manager=true -Dtests.locale=uk-UA -Dtests.timezone=Asia/Dushanbe -Dcompiler.java=13

./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.geogrid.GeoHashGridAggregatorTests.testBounds" -Dtests.seed=2B983432901303C6 -Dtests.security.manager=true -Dtests.locale=pl-PL -Dtests.timezone=Asia/Aqtobe -Dcompiler.java=13

Suite: Test class org.elasticsearch.search.aggregations.bucket.geogrid.GeoTileGridAggregatorTests
  1> [2020-01-16T19:19:26,727][INFO ][o.e.s.a.b.g.GeoTileGridAggregatorTests] [testBounds] before test
  1> [2020-01-16T19:19:27,781][INFO ][o.e.s.a.b.g.GeoTileGridAggregatorTests] [testBounds] after test
  2> REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.search.aggregations.bucket.geogrid.GeoTileGridAggregatorTests.testBounds" -Dtests.seed=2B983432901303C6 -Dtests.security.manager=true -Dtests.locale=uk-UA -Dtests.timezone=Asia/Dushanbe -Dcompiler.java=13
  2> java.lang.AssertionError
  2> NOTE: leaving temporary files on disk at: /home/polyfractal/projects/es/elasticsearch/server/build/testrun/test/temp/org.elasticsearch.search.aggregations.bucket.geogrid.GeoTileGridAggregatorTests_2B983432901303C6-001
  2> NOTE: test params are: codec=Asserting(Lucene84): {}, docValues:{location=DocValuesFormat(name=Asserting)}, maxPointsInLeafNode=1436, maxMBSortInHeap=5.102465863522001, sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@7b4d5a39), locale=uk-UA, timezone=Asia/Dushanbe
  2> NOTE: Linux 4.15.0-72-generic amd64/Oracle Corporation 11.0.1 (64-bit)/cpus=32,threads=1,free=520346880,total=536870912
  2> NOTE: All tests run in this JVM: [GeoTileGridAggregatorTests]

https://gradle-enterprise.elastic.co/s/ljbmapfrpq6vy
@polyfractal polyfractal added :Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI labels Jan 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

polyfractal added a commit that referenced this issue Jan 16, 2020
@polyfractal
Mute GeoGridAggregatorTestCase#testBounds()
e2ca93b 
Tracking issue: #51103
polyfractal added a commit that referenced this issue Jan 16, 2020
@polyfractal
Mute GeoGridAggregatorTestCase#testBounds()
aa66d1a 
Tracking issue: #51103
@talevy talevy mentioned this issue Jan 16, 2020
Merged
talevy added a commit to talevy/elasticsearch that referenced this issue Jan 16, 2020
@talevy
Fix geogrid with bounds test edge cases
5bb7b1f 
This commit modifies the bounding box for geogrid unit tests
to only consider bounding boxes that have significant longitudinal
width and whose coordinates are normalized to quantized space

Closes elastic#51103.
@polyfractal polyfractal mentioned this issue Jan 22, 2020
Closed
@astefan astefan mentioned this issue Jan 22, 2020
Merged
@astefan
Copy link
Contributor

astefan commented Jan 22, 2020

Muted in 7.6 with 8ddf918.

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@polyfractal @SivagurunathanV
Mute GeoGridAggregatorTestCase#testBounds()
df30a81 
Tracking issue: elastic#51103
talevy added a commit that referenced this issue Jan 27, 2020
@talevy
Fix geogrid with bounds test edge cases (#51118)
7071d92 
This commit modifies the bounding box for geogrid unit tests
to only consider bounding boxes that have significant longitudinal
width and whose coordinates are normalized to quantized space

Closes #51103.
talevy added a commit that referenced this issue Jan 27, 2020
@talevy
Fix geogrid with bounds test edge cases (#51118)
fc2d875 
This commit modifies the bounding box for geogrid unit tests
to only consider bounding boxes that have significant longitudinal
width and whose coordinates are normalized to quantized space

Closes #51103.
talevy added a commit that referenced this issue Jan 27, 2020
@talevy
Fix geogrid with bounds test edge cases (#51118)
ab5a9a9 
This commit modifies the bounding box for geogrid unit tests
to only consider bounding boxes that have significant longitudinal
width and whose coordinates are normalized to quantized space

Closes #51103.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talevy talevy

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix geogrid with bounds test edge cases talevy/elasticsearch
4 participants
@talevy @astefan @polyfractal @elasticmachine